Bug: 2.0.0 breaks methods to access vars

[ineu]

Sorry for reporting in Discussions, but the Issues are not available, so there's no better place.

In 2.0.0 a bunch of methods I've used to access node variables are no longer working (they are now private):

• node.to_h
• node.VAR_NAME
• node.fetch("VAR_NAME")

The only thing that works is [], but it's the worst possible option because it defaults to nil making it very easy to make a typo and get unexpected nil (the very reason I almost always use fetch in Ruby).
While node.VAR_NAME is a bit too magical, the to_h and fetch methods should work: fetch for the reason described, and to_h to debug the variables.

[takumin]

Thanks for the detailed report — the reproduction was spot on. Opened a fix:
#157

Root cause: mruby 3.4.0 (which 2.0.0 upgraded to) started enforcing method visibility,
and when a method is not found the VM falls back to method_missing but then checks
the visibility of method_missing itself, while still naming the originally called
method in the error. MItamae::Node#method_missing was defined under private, as is
conventional in Ruby, so every delegated call started failing. Node#respond_to? was
in the same private section, so it broke too. node[:key] kept working only because
[] is a real public method.

With the PR applied:

node.foo               #=> "bar"
node.fetch('foo')      #=> "bar"
node.fetch('nope')     #=> KeyError: Key not found: "nope"
node.to_h              #=> #<Hashie::Mash foo="bar" nested=#<Hashie::Mash a=1>>
node.respond_to?(:foo) #=> true

So fetch raises on a typo again, which was your main point.

I also reported the underlying mruby behavior upstream, since it diverges from CRuby:
mruby/mruby#6974

[takumin]

@ineu

The fix has been merged (#157) and shipped in v2.0.2:
https://github.com/itamae-kitchen/mitamae/releases/tag/v2.0.2

node.VAR_NAME, node.fetch, node.to_h and node.respond_to? work again, and fetch raises KeyError on a typo as it did before v2.0.0.

Thanks again for the clear report.

[ineu]

Thank you!