Skip to content

Wrong A matrix? #8

Description

@luitjens
    if n > m:
        v = svd_1d(matrixFor1D, epsilon=epsilon)  # next singular vector
        u_unnormalized = np.dot(A, v)
        sigma = norm(u_unnormalized)  # next singular value
        u = u_unnormalized / sigma
    else:
        u = svd_1d(matrixFor1D, epsilon=epsilon)  # next singular vector
        v_unnormalized = np.dot(A.T, u)
        sigma = norm(v_unnormalized)  # next singular value
        v = v_unnormalized / 

In the above code you multiply by A or A.T. Shouldn't you be using the updated matrix: matrixFor1D or matrixFor1D.T?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions