improve signature testing#730
Merged
Merged
Conversation
manovotn
reviewed
Jun 5, 2026
manovotn
left a comment
manovotn
left a comment
Contributor
There was a problem hiding this comment.
Just two small notes, otherwise looks good.
manovotn
reviewed
Jun 5, 2026
| <artifactId>jakarta.cdi-tck-core-impl</artifactId> | ||
| <version>${version.cdi-tck}</version> | ||
| <type>sigfile</type> | ||
| <classifier>jdk17</type> |
Contributor
There was a problem hiding this comment.
Suggested change
| <classifier>jdk17</type> | |
| <classifier>jdk17</classifier> |
Member
Author
There was a problem hiding this comment.
Done. Also squashed the commits.
Contributor
|
We had some back and forth with Ladislav over Zulip and I think this version is good to go. Thanks for delving into this @Ladicek! |
The statically generated signature file in `impl/src/main/resources` is gone. The signature file is now generated during each build, and instead of attaching the static file using the Build Helper Maven plugin, the generated file is attached automatically by the Sigtest Maven plugin. Further, a few more static files were removed, because they are not useful. The only actually useful file was moved from `impl` to `dist-build`, because that's the only use site. The AsciiDoc documents in `dist-build` were slightly edited for better formatting and to remove typos, but I didn't do any major surgery.
manovotn
approved these changes
Jun 8, 2026
manovotn
left a comment
manovotn
left a comment
Contributor
There was a problem hiding this comment.
As far as I can tell, this is looking good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statically generated signature file in
impl/src/main/resourcesis gone. The signature file is now generated during each build, and instead of attaching the static file using the Build Helper Maven plugin, the generated file is attached automatically by the Sigtest Maven plugin.Further, a few more static files were removed, because they are not useful. The only actually useful file was moved from
impltodist-build, because that's the only use site.The AsciiDoc documents in
dist-buildwere slightly edited for better formatting and to remove typos, but I didn't do any major surgery.