Skip to content

FINAL-REVIEW-001: Run repository-wide release-readiness review #46

Description

@jamalfrnk

Problem

After all other issues in this mission complete, a single consolidated review is needed to classify every remaining item as complete, external dependency, accepted risk, deferred, or production blocker -- rather than declaring readiness because the dashboard looks polished.

Repository evidence

N/A -- this issue runs last and evaluates the cumulative state of everything else in this milestone.

Risk

P0 -- this is the gate before any real production/Replit deployment recommendation.

Scope

Run every test and quality gate (server + client); desktop and mobile end-to-end tests; wallet tests across MetaMask/Rabby/Phantom EVM; guest-session tests; market-provider failure tests; WS reconnect tests; backtesting correctness tests; paper-execution correctness tests; accessibility tests; dependency/secret scans; production builds; run the production server locally; verify SPA routes, same-origin WS, health/readiness, no live-execution path, disclosures, server-enforced entitlements, Replit docs against actual commands; review unresolved issues; reconcile documentation with implementation.

Non-goals

Not fixing newly discovered defects in this issue itself -- classify them (blocker/deferred/accepted-risk) and open follow-up issues instead, to keep this issue's scope bounded to review+classification.

Dependencies

Every other issue in this milestone (UI-RESP-001 through REPLIT-READY-001).

Proposed implementation

A structured checklist run manually against the actual repo state at that time, producing a docs/production-readiness/backlog.md (or update to the existing plan doc) classifying every item.

Acceptance criteria

Every listed check has been actually run (not assumed) with its result recorded; every open gap has an explicit classification and, where applicable, a linked follow-up issue.

Definition of done

docs/production-readiness/backlog.md published; independent reviewer confirms the classifications match observed repository state, not just the implementer's summary.

Test plan

Full regression run across both packages; this issue's test plan is running every other issue's test suite together and confirming no regressions from integration.

Security review

Confirms no live-trading path was introduced anywhere across the whole mission's changes (structural regression check, ideally backed by a small automated guard rather than only manual review).

Accessibility review

Confirms accessibility requirements from UI-RESP-001/CHART-001/TEST-CLIENT-001 still hold in aggregate.

Observability requirements

Confirms OBS-PROD-001's metrics surface reflects real activity across a full manual walkthrough.

Performance considerations

Cross-references PERF-001's measured numbers for currency.

Rollback plan

N/A -- review/classification only produces documentation, no code change beyond any explicitly-scoped follow-up fixes.

Documentation requirements

docs/production-readiness/backlog.md.

Completion evidence

(added on merge)

Reviewer verdict

(pending)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Security, data-integrity, correctness, or release-blocking riskepic:ciCI/CD and release engineering

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions