From cd322387692ad08f3f16591c127098563dedc2c5 Mon Sep 17 00:00:00 2001 From: James Burton Date: Fri, 14 Aug 2026 23:31:55 +0100 Subject: [PATCH] fix(tests): use [SkippableFact] for gated safetensors E2E tests (#392) Mistral7B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent, Mixtral8x7B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent, and Qwen15MoeA27B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent were declared [Fact] instead of [SkippableFact], so the Xunit.SkipException thrown by RunGatedSafetensorsSmoke when the gated checkpoint is absent was counted as a test FAILURE instead of a skip, making the Integration Tests CI job red on every PR. Swept tests/ for other [Fact]/[Theory] methods that throw SkipException (via Skip.If/Skip.IfNot/SkipException) without the Skippable attribute; no other occurrences found. --- .../Models/Loaders/RealHfSafetensorsEndToEndTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/DotLLM.Tests.Integration/Models/Loaders/RealHfSafetensorsEndToEndTests.cs b/tests/DotLLM.Tests.Integration/Models/Loaders/RealHfSafetensorsEndToEndTests.cs index a2d29229..e3588b03 100644 --- a/tests/DotLLM.Tests.Integration/Models/Loaders/RealHfSafetensorsEndToEndTests.cs +++ b/tests/DotLLM.Tests.Integration/Models/Loaders/RealHfSafetensorsEndToEndTests.cs @@ -240,7 +240,7 @@ public void Qwen25_0_5B_LoadsAndForwardsEndToEnd() // Phase 5 gated real-weight coverage for previously tiny-random-only archs // ──────────────────────────────────────────────────────────────────── - [Fact] + [SkippableFact] public void Mistral7B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent() => RunGatedSafetensorsSmoke( envVar: "DOTLLM_MISTRAL_7B_CHECKPOINT_PATH", @@ -254,7 +254,7 @@ public void Mistral7B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent() Assert.True(config.NumLayers >= 32); }); - [Fact] + [SkippableFact] public void Mixtral8x7B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent() => RunGatedSafetensorsSmoke( envVar: "DOTLLM_MIXTRAL_8X7B_CHECKPOINT_PATH", @@ -269,7 +269,7 @@ public void Mixtral8x7B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent() Assert.True(config.Moe.NumExpertsPerTok >= 2); }); - [Fact] + [SkippableFact] public void Qwen15MoeA27B_LoadsAndForwardsEndToEnd_WhenCheckpointPresent() => RunGatedSafetensorsSmoke( envVar: "DOTLLM_QWEN15_MOE_A27B_CHECKPOINT_PATH",