Error in `arrange_variables`

[hyunjimoon]

I ran a vensim xmile file and encountered the following error:

Error in sum(undefined_vars) : invalid 'type' (list) of argument

the reason seems to be rh_vars is empty which I fixed by adding the following in this line. This makes sure sum(undefined_vars) happens only when undefined_vars is nonempty.

    if(length(undefined_vars) != 0){
      n_und_var <- sum(undefined_vars)
    }
    else{
      n_und_var <- 0
    }

[jandraor]

Hi Hyunji,

Thanks for this comment. Very much appreciated. I wonder if something upstream in the code failed that led to this error. Would it be possible to share your model or a simplified one that triggers that error? I'd like to add a unit test & include your suggested lines of code.

Thanks.

PS. Here's my email: jair.andrade@nuigalway.ie

[hyunjimoon]

I will sent you the two .xmile file below via mail. To reproduce, run the following in your SDR_Bayes package this line.

> filepath   <- "./models/issue2.xmile"
> mdl        <- read_xmile(filepath) # const_list = const_list
Error in translate_ifelse(equation, vendor) : 
  Only one IF-ELSE statement per variable is permitted

The first error is because I had two IF-ELSE statement in issue2.xmile.

if_then_else(DataForCalib[Sims,Data]=:NA:,0,if_then_else(abs(SimOutTrans[Sims,Data]-DataForCalib[Sims,Data])>kErr*MStdevData[Sims,Data],
	DataForCalib[Sims,Data]+if_then_else(SimOutTrans[Sims,Data]-DataForCalib[Sims,Data]>0,1,-1)*sqrt(
	2*kErr*MStdevData[Sims,Data]*abs(SimOutTrans[Sims,Data]-DataForCalib[Sims,Data])),SimOutTrans[Sims,Data]))					

So I changed by replacing the above to 0 which resulted in another error. It may be because of the missing const_list but as you can see from the xmile file, there are too many consts. Is there any way to read const automatically from xmile file?

> filepath   <- "./models/issue2_replaceIFELSE_to_0.xmile"
> mdl        <- read_xmile(filepath) # const_list = const_list
Error in sum(undefined_vars) : invalid 'type' (list) of argument

P.S. Also, could you please consider supporting Max, Min and nested if_else 😀 ? I tried via you operator files but for some reason it didn't work smoothly. Thanks for making this awesome package!