diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 77ff56e0..8c675af9 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -235,7 +235,7 @@ For complete documentation, see [DEBUG_LOGGING.md](DEBUG_LOGGING.md). [DEBUG] ├─ Extracting builder definition from: test.Project [DEBUG] │ ├─ Builder will be generated as: test.ProjectBuilder [DEBUG] │ ├─ Analysing setters for finding fields -[DEBUG] │ │ ├─ Analyzing method: setName with 1 parameter(s) +[DEBUG] │ │ ├─ Analyzing method: setName(java.lang.String) [DEBUG] │ │ │ └─ Adding field: name (type: java.lang.String) [DEBUG] │ └─ Processed 1 possible setters: added 1 fields, skipped 0 [DEBUG] ├─ Code generation for builder: ProjectBuilder diff --git a/docs/DEBUG_LOGGING.md b/docs/DEBUG_LOGGING.md index a236e123..c4023aeb 100644 --- a/docs/DEBUG_LOGGING.md +++ b/docs/DEBUG_LOGGING.md @@ -94,9 +94,9 @@ When debug logging is enabled, you'll see detailed output with visual separators [INFO] [DEBUG] ├─ Extracting builder definition from: org.example.PersonDto [INFO] [DEBUG] │ ├─ Builder will be generated as: org.example.PersonDtoBuilder [INFO] [DEBUG] │ ├─ Analysing setters for finding fields -[INFO] [DEBUG] │ │ ├─ Analyzing method: setName with 1 parameter(s) +[INFO] [DEBUG] │ │ ├─ Analyzing method: setName(java.lang.String) [INFO] [DEBUG] │ │ │ └─ Adding field: name (type: java.lang.String) -[INFO] [DEBUG] │ │ ├─ Analyzing method: setAge with 1 parameter(s) +[INFO] [DEBUG] │ │ ├─ Analyzing method: setAge(int) [INFO] [DEBUG] │ │ │ └─ Adding field: age (type: int) [INFO] [DEBUG] │ └─ Processed 2 possible setters: added 2 fields, skipped 0 [INFO] [DEBUG] ├─ Code generation for builder: PersonDtoBuilder diff --git a/processor/src/main/java/org/javahelpers/simple/builders/processor/processing/BuilderDefinitionCreator.java b/processor/src/main/java/org/javahelpers/simple/builders/processor/processing/BuilderDefinitionCreator.java index 220aeb03..f5f9620a 100644 --- a/processor/src/main/java/org/javahelpers/simple/builders/processor/processing/BuilderDefinitionCreator.java +++ b/processor/src/main/java/org/javahelpers/simple/builders/processor/processing/BuilderDefinitionCreator.java @@ -191,9 +191,7 @@ private static List extractSetterFields( result.getBuilderTypeName(), result.getGenerics()); for (ExecutableElement mth : methods) { - context.debugStartOperation( - "Analyzing method: %s with %d parameter(s)", - mth.getSimpleName(), mth.getParameters().size()); + context.debugStartOperation("Analyzing method: %s", mth.toString()); if (isMethodRelevantForBuilder(mth, context)) { // Extract the original field name from the setter method (before any renaming) diff --git a/processor/src/test/java/org/javahelpers/simple/builders/processor/BuilderProcessorTest.java b/processor/src/test/java/org/javahelpers/simple/builders/processor/BuilderProcessorTest.java index 62fc1699..cbb3f980 100644 --- a/processor/src/test/java/org/javahelpers/simple/builders/processor/BuilderProcessorTest.java +++ b/processor/src/test/java/org/javahelpers/simple/builders/processor/BuilderProcessorTest.java @@ -35,7 +35,6 @@ import javax.tools.JavaFileObject; import org.javahelpers.simple.builders.processor.testing.ProcessorAsserts; import org.javahelpers.simple.builders.processor.testing.ProcessorTestUtils; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; /** Tests for the {@link BuilderProcessor} class. */ @@ -104,7 +103,7 @@ void shouldLogDebugMessagesWhenVerboseModeEnabled() { "[DEBUG] ├─ Extracting builder definition from: test.VerboseTest", "[DEBUG] │ ├─ Builder will be generated as: test.VerboseTestBuilder", "[DEBUG] │ ├─ Analysing setters for finding fields", - "[DEBUG] │ │ ├─ Analyzing method: setName with 1 parameter(s)", + "[DEBUG] │ │ ├─ Analyzing method: setName(java.lang.String)", "[DEBUG] │ │ │ ├─ Processing method generators", "[DEBUG] │ │ │ │ ├─ Applying: BasicSetterGenerator (priority: 100)", "[DEBUG] │ │ │ │ ├─ Applying: StringFormatHelperGenerator (priority: 80)", @@ -2682,7 +2681,6 @@ public class InnerClass { } @Test - @Disabled("Missing feature: #131") void shouldHandleOverloadedSettersForSameFieldWithoutConflicts() { // Given String packageName = "test"; @@ -2697,8 +2695,8 @@ void shouldHandleOverloadedSettersForSameFieldWithoutConflicts() { private java.util.List names; public java.util.List getNames() { return names; } - public void setNames(String[] names) { this.names = names; } - public void setNames(String... names) { this.names = java.util.List.of(names); } + public void setNames(String[] names) { this.names = java.util.List.of(names); } + public void setNames(java.util.List names) { this.names = names; } """); // When