diff --git a/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java b/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java index 11a15bb..941d49d 100644 --- a/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java +++ b/src/main/java/org/jenkinsci/plugins/GitLabSecurityRealm.java @@ -470,16 +470,14 @@ public Authentication authenticate(Authentication authentication) throws Authent if (authentication instanceof GitLabAuthenticationToken) { return authentication; } - if (authentication instanceof UsernamePasswordAuthenticationToken) { + if (authentication instanceof UsernamePasswordAuthenticationToken token) { try { - UsernamePasswordAuthenticationToken token = - (UsernamePasswordAuthenticationToken) authentication; GitLabAuthenticationToken gitlab = new GitLabAuthenticationToken( token.getCredentials().toString(), getGitlabApiUri(), TokenType.PRIVATE); SecurityContextHolder.getContext().setAuthentication(gitlab); return gitlab; } catch (GitLabApiException e) { - throw new RuntimeException(e); + throw new BadCredentialsException("Authentication failed", e); } } throw new BadCredentialsException("Unexpected authentication type: " + authentication);