[Request] Uniform Shift + Enter behavior.

[piotrenewicz]

Currently this plugin works as follows:

If there is only 1 line Shift+Enter will add another.
If there is more lines Shift+Enter will send.

If there is only 1 line Enter will send.
If there is more lines Enter will add lines. 

I find this behavior confusing,
and it seems there's a symmetry between those two modes.

I've decided to fix this for myself, by making a small change.
With my Pull request it will work as follows:

Shift+Enter will always add a new line
Enter will always send.

I've also updated README to reflect this change in the explanation.

[piotrenewicz]

While I was testing my changes.
I've noticed that sending multiple lines, doesn't reset the size of input field back to 1.
Just in case this was intentional, I'm splitting this small fix into a second Pull Request.

[jneilliii]

Quoting this issue:

From UX perspective it may still be useful to add the suggested checkbox because for quick single line actions (which are probably most commonly used) having to press only Enter is quicker and easier than having to press shift-Enter.

was the reasoning behind the current behavior and released as part of version 0.1.5. not sure if reverting is the way to go and maybe having a checkbox would be the better option to switch between modes.

[piotrenewicz]

This doesn't conflict with the points raised in the issue you mentioned.
Single line mode is still default, and if you never press Shift+Enter, it will behave same as without the plugin.

The logic for history scrolling wasn't changed.
Up Down arrows still work for scrolling through history of single-line commands.

This changes only multi-line mode behavior, to match the single line mode.
So that the buttons keep their functions, in both modes.
Instead of swapping what buttons do, depending on how many lines are on screen.

[jneilliii]

Maybe I'm not explaining it properly, the reasoning behind the shift+enter in the multi-line mode for submit is because it's more natural to hit enter in a multi-line textarea to go to the next line. Similar to entering comments here in GitHub, hitting enter doesn't press the comment button. If I understand your PR correctly it makes Enter always submit the form, which would be counter-intuitive in a multi-line textarea.

[piotrenewicz]

You do understand the PR correctly.
This multi-line behavior seems more intuitive to me:
Enter for confirm, Shift for more lines.
But i can see your point, and people who use this are probably used to that.

So perhaps a setting between those two behaviors, can be next on the list of checkboxes to consider adding.
Feel free to close this then.