Issue 02: add wallet list model unit-test seam and coverage

Author: johnny9

qml/models/walletlistmodel.cpp

@@ -5,13 +5,42 @@
 #include <qml/models/walletlistmodel.h>
 
 #include <interfaces/node.h>
+#include <interfaces/wallet.h>
 
 #include <QSet>
 
-WalletListModel::WalletListModel(interfaces::Node& node, QObject *parent)
-: QAbstractListModel(parent)
-, m_node(node)
+#include <cassert>
+#include <memory>
+
+namespace {
+class WalletLoaderDataSource final : public WalletListModel::DataSource
+{
+public:
+    explicit WalletLoaderDataSource(interfaces::Node& node)
+        : m_node(node)
+    {
+    }
+
+    WalletListModel::WalletDirEntries listWalletDir() override
+    {
+        return m_node.walletLoader().listWalletDir();
+    }
+
+private:
+    interfaces::Node& m_node;
+};
+} // namespace
+
+WalletListModel::WalletListModel(interfaces::Node& node, QObject* parent)
+    : WalletListModel(std::make_unique<WalletLoaderDataSource>(node), parent)
+{
+}
+
+WalletListModel::WalletListModel(std::unique_ptr<DataSource> data_source, QObject* parent)
+    : QAbstractListModel(parent)
+    , m_data_source(std::move(data_source))
 {
+    assert(m_data_source);
 }
 
 void WalletListModel::listWalletDir()
@@ -23,10 +52,12 @@ void WalletListModel::listWalletDir()
         existing_names.insert(name);
     }
 
-    for (const auto& [path, info] : m_node.walletLoader().listWalletDir()) {
+    for (const auto& [path, info] : m_data_source->listWalletDir()) {
+        Q_UNUSED(info);
         QString qname = QString::fromStdString(path);
         if (!existing_names.contains(qname)) {
-            addItem({ qname });
+            addItem({qname});
+            existing_names.insert(qname);
         }
     }
 }

qml/models/walletlistmodel.h

@@ -5,10 +5,14 @@
 #ifndef BITCOIN_QML_MODELS_WALLETLISTMODEL_H
 #define BITCOIN_QML_MODELS_WALLETLISTMODEL_H
 
-#include <interfaces/wallet.h>
 #include <QAbstractListModel>
 #include <QList>
 
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 namespace interfaces {
 class Node;
 }
@@ -18,7 +22,17 @@ class WalletListModel : public QAbstractListModel
     Q_OBJECT
 
 public:
-    WalletListModel(interfaces::Node& node, QObject *parent = nullptr);
+    using WalletDirEntries = std::vector<std::pair<std::string, std::string>>;
+
+    class DataSource
+    {
+    public:
+        virtual ~DataSource() = default;
+        virtual WalletDirEntries listWalletDir() = 0;
+    };
+
+    WalletListModel(interfaces::Node& node, QObject* parent = nullptr);
+    WalletListModel(std::unique_ptr<DataSource> data_source, QObject* parent = nullptr);
     ~WalletListModel() = default;
 
     enum Roles {
@@ -40,7 +54,7 @@ public Q_SLOTS:
     void addItem(const Item &item);
 
     QList<Item> m_items;
-    interfaces::Node& m_node;
+    std::unique_ptr<DataSource> m_data_source;
 };
 
 #endif // BITCOIN_QML_MODELS_WALLETLISTMODEL_H

test/CMakeLists.txt

@@ -30,6 +30,7 @@ add_executable(bitcoinqml_unit_tests
   test_proxysettings.cpp
   test_sendrecipientslistmodel.cpp
   test_desktopwindowbehaviormodel.cpp
+  test_walletlistmodel.cpp
   test_walletloaderror.cpp
   test_walletlifecycleadapter.cpp
   test_walletrestoreadapter.cpp
@@ -68,6 +69,7 @@ add_executable(bitcoinqml_unit_tests
   ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/rpccommandexecutor.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/proxysettings.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/desktopwindowbehaviormodel.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/walletlistmodel.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/walletloaderror.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/walletlifecycleadapter.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/../qml/models/walletrestoreadapter.cpp

test/test_unit_tests_main.cpp

@@ -30,6 +30,7 @@ int RunSendRecipientTests(int argc, char* argv[]);
 int RunAddressBookModelTests(int argc, char* argv[]);
 int RunSendRecipientsListModelTests(int argc, char* argv[]);
 int RunDesktopWindowBehaviorModelTests(int argc, char* argv[]);
+int RunWalletListModelTests(int argc, char* argv[]);
 int RunWalletLoadErrorTests(int argc, char* argv[]);
 int RunWalletLifecycleAdapterTests(int argc, char* argv[]);
 int RunWalletRestoreAdapterTests(int argc, char* argv[]);
@@ -74,6 +75,7 @@ int main(int argc, char* argv[])
     status |= RunAddressBookModelTests(argc, argv);
     status |= RunSendRecipientsListModelTests(argc, argv);
     status |= RunDesktopWindowBehaviorModelTests(argc, argv);
+    status |= RunWalletListModelTests(argc, argv);
     status |= RunWalletLoadErrorTests(argc, argv);
     status |= RunWalletLifecycleAdapterTests(argc, argv);
     status |= RunWalletRestoreAdapterTests(argc, argv);

test/test_walletlistmodel.cpp

@@ -0,0 +1,103 @@
+// Copyright (c) 2026 The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or http://www.opensource.org/licenses/mit-license.php.
+
+#include <qml/models/walletlistmodel.h>
+
+#include <QtTest/QtTest>
+
+#include <memory>
+
+class FakeWalletListDataSource final : public WalletListModel::DataSource
+{
+public:
+    WalletListModel::WalletDirEntries m_entries{};
+
+    WalletListModel::WalletDirEntries listWalletDir() override
+    {
+        return m_entries;
+    }
+};
+
+class WalletListModelTests : public QObject
+{
+    Q_OBJECT
+
+private Q_SLOTS:
+    void role_names_expose_name_key();
+    void list_wallet_dir_adds_entries_and_filters_duplicates();
+    void subsequent_list_wallet_dir_only_appends_new_wallets();
+    void invalid_index_returns_empty_variant();
+};
+
+void WalletListModelTests::role_names_expose_name_key()
+{
+    auto source = std::make_unique<FakeWalletListDataSource>();
+    WalletListModel model(std::move(source));
+
+    const QHash<int, QByteArray> roles = model.roleNames();
+    QVERIFY(roles.contains(WalletListModel::NameRole));
+    QCOMPARE(roles.value(WalletListModel::NameRole), QByteArrayLiteral("name"));
+}
+
+void WalletListModelTests::list_wallet_dir_adds_entries_and_filters_duplicates()
+{
+    auto source = std::make_unique<FakeWalletListDataSource>();
+    source->m_entries = {
+        {"wallet-alpha", "sqlite"},
+        {"wallet-beta", "sqlite"},
+        {"wallet-alpha", "sqlite"},
+    };
+
+    WalletListModel model(std::move(source));
+    model.listWalletDir();
+
+    QCOMPARE(model.rowCount(), 2);
+    QCOMPARE(model.data(model.index(0, 0), WalletListModel::NameRole).toString(), QStringLiteral("wallet-alpha"));
+    QCOMPARE(model.data(model.index(1, 0), WalletListModel::NameRole).toString(), QStringLiteral("wallet-beta"));
+}
+
+void WalletListModelTests::subsequent_list_wallet_dir_only_appends_new_wallets()
+{
+    auto source = std::make_unique<FakeWalletListDataSource>();
+    auto* source_ptr = source.get();
+    source_ptr->m_entries = {
+        {"wallet-alpha", "sqlite"},
+        {"wallet-beta", "sqlite"},
+    };
+
+    WalletListModel model(std::move(source));
+    model.listWalletDir();
+
+    source_ptr->m_entries = {
+        {"wallet-beta", "sqlite"},
+        {"wallet-gamma", "sqlite"},
+    };
+    model.listWalletDir();
+
+    QCOMPARE(model.rowCount(), 3);
+    QCOMPARE(model.data(model.index(2, 0), WalletListModel::NameRole).toString(), QStringLiteral("wallet-gamma"));
+}
+
+void WalletListModelTests::invalid_index_returns_empty_variant()
+{
+    auto source = std::make_unique<FakeWalletListDataSource>();
+    source->m_entries = {{"wallet-alpha", "sqlite"}};
+
+    WalletListModel model(std::move(source));
+    model.listWalletDir();
+
+    QVERIFY(!model.data(QModelIndex{}, WalletListModel::NameRole).isValid());
+    QVERIFY(!model.data(model.index(5, 0), WalletListModel::NameRole).isValid());
+}
+
+int RunWalletListModelTests(int argc, char* argv[])
+{
+    WalletListModelTests tests;
+    return QTest::qExec(&tests, argc, argv);
+}
+
+#ifndef BITCOINQML_NO_TEST_MAIN
+QTEST_MAIN(WalletListModelTests)
+#endif
+#include "test_walletlistmodel.moc"