Issue 18: add PSBT operations E2E with clipboard recovery flow

Author: johnny9

doc/test-bridge.md

@@ -133,6 +133,24 @@ Reads the `text` property from a named QML object.
 ← {"text": "File not found"}
 ```
 
+#### `get_clipboard_text`
+
+Reads clipboard text from the GUI process.
+
+```json
+→ {"cmd": "get_clipboard_text"}
+← {"text": "bitcoin:bc1q..."}
+```
+
+#### `set_clipboard_text`
+
+Sets clipboard text in the GUI process.
+
+```json
+→ {"cmd": "set_clipboard_text", "text": "cHNidP8..."}
+← {"ok": true}
+```
+
 #### `wait_for_page`
 
 Blocks until the named QML object exists and is visible, or the timeout
@@ -210,6 +228,8 @@ page = gui.get_current_page()
 text = gui.get_text("errorLabel")
 visible = gui.get_property("importButton", "visible")
 objects = gui.list_objects()
+clipboard_text = gui.get_clipboard_text()
+gui.set_clipboard_text(clipboard_text)
 gui.wait_for_property("walletBadge", "loading", value=False)
 gui.save_screenshot("/tmp/qml_debug.png")
 
@@ -233,14 +253,15 @@ headless GUI instance automatically, or attach to an already-running app.
 python3 test/functional/qml_test_bridge_sanity.py
 python3 test/functional/qml_test_onboarding.py
 python3 test/functional/qml_test_send_receive.py
+python3 test/functional/qml_test_psbt_operations.py
 ```
 
-To save step screenshots during the onboarding/send/receive E2E tests, pass a
-directory path:
+To save step screenshots during E2E tests, pass a directory path:
 
 ```bash
 python3 test/functional/qml_test_onboarding.py --screenshot-dir /tmp/qml-shots
 python3 test/functional/qml_test_send_receive.py --screenshot-dir /tmp/qml-shots
+python3 test/functional/qml_test_psbt_operations.py --screenshot-dir /tmp/qml-shots
 ```
 
 The harness starts `bitcoin-core-app` with `QT_QPA_PLATFORM=offscreen`,
@@ -273,6 +294,7 @@ and does **not** launch or terminate the application.
 | `qml_test_bridge_sanity.py` | Bridge protocol smoke test: list_objects, get_current_page, wait_for_property/get_property, screenshot capture, error handling, wait_for_page timeout |
 | `qml_test_onboarding.py` | Walks through the full onboarding flow (Cover → Strengthen → Blockclock → StorageLocation → StorageAmount → Connection) |
 | `qml_test_send_receive.py` | Full send/receive E2E: create/fund wallet via RPC, create receive request in QML, send in QML, confirm via RPC, verify Activity update |
+| `qml_test_psbt_operations.py` | PSBT operations E2E: export unsigned PSBT from review, assert invalid-clipboard import failure, recover via valid import, sign/finalize, broadcast, verify txid in mempool |
 
 ## Prerequisite: `objectName` annotations
 
@@ -341,6 +363,7 @@ their buttons:
 | `test/functional/qml_test_bridge_sanity.py` | Bridge protocol sanity test |
 | `test/functional/qml_test_onboarding.py` | Onboarding flow walk-through test |
 | `test/functional/qml_test_send_receive.py` | Send/receive end-to-end test |
+| `test/functional/qml_test_psbt_operations.py` | PSBT operations end-to-end test |
 
 ## Security considerations
 

qml/pages/wallet/PsbtOperations.qml

@@ -149,7 +149,10 @@ Page {
                             return
                         }
                         broadcastTxid = ""
-                        root.applyResult(wallet.inspectPsbtFromClipboard(Clipboard.text))
+                        const clipboardText = typeof Clipboard.text === "function"
+                            ? Clipboard.text()
+                            : Clipboard.text
+                        root.applyResult(wallet.inspectPsbtFromClipboard(clipboardText))
                     }
                 }
 

qml/test/testbridge.cpp

@@ -209,6 +209,8 @@ QByteArray TestBridge::processCommand(const QByteArray& json_cmd)
         return cmdGetText(obj.value(QStringLiteral("objectName")).toString());
     } else if (cmd == QLatin1String("get_clipboard_text")) {
         return cmdGetClipboardText();
+    } else if (cmd == QLatin1String("set_clipboard_text")) {
+        return cmdSetClipboardText(obj.value(QStringLiteral("text")).toString());
     } else if (cmd == QLatin1String("save_screenshot")) {
         return cmdSaveScreenshot(obj.value(QStringLiteral("path")).toString());
     } else if (cmd == QLatin1String("list_objects")) {
@@ -331,6 +333,22 @@ QByteArray TestBridge::cmdClick(const QString& object_name)
         return index >= 0 && meta->method(index).invoke(obj, Qt::DirectConnection);
     };
 
+    auto try_emit_clicked = [obj](const QMetaObject* meta) {
+        if (const int clicked_index = meta->indexOfSignal("clicked()"); clicked_index >= 0) {
+            if (meta->method(clicked_index).invoke(obj, Qt::DirectConnection)) {
+                return true;
+            }
+        }
+
+        if (const int clicked_bool_index = meta->indexOfSignal("clicked(bool)"); clicked_bool_index >= 0) {
+            if (meta->method(clicked_bool_index).invoke(obj, Qt::DirectConnection, Q_ARG(bool, true))) {
+                return true;
+            }
+        }
+
+        return false;
+    };
+
     auto* item = qobject_cast<QQuickItem*>(obj);
     const QMetaObject* meta = obj->metaObject();
     const QString class_name = QString::fromLatin1(meta->className());
@@ -360,18 +378,17 @@ QByteArray TestBridge::cmdClick(const QString& object_name)
     // Some custom controls (for example Setting.qml) route interaction through
     // an internal MouseArea and do not react correctly to click().
     if (item && class_name.startsWith(QStringLiteral("Setting_"))) {
-        const int clicked_index = meta->indexOfSignal("clicked()");
-        if (clicked_index >= 0 && meta->method(clicked_index).invoke(obj, Qt::DirectConnection)) {
+        if (try_emit_clicked(meta)) {
             return return_ok();
         }
     }
 
-    // Qt Quick Controls and gui-qml *Button controls are not reliably invokable
-    // via click()/toggle() in this harness. Prefer firing clicked(), then fall
-    // back to pointer synthesis.
-    if (item && class_name.contains(QStringLiteral("Button_"))) {
-        const int button_clicked_index = meta->indexOfSignal("clicked()");
-        if (button_clicked_index >= 0 && meta->method(button_clicked_index).invoke(obj, Qt::DirectConnection)) {
+    // Qt Quick Controls and gui-qml button-style controls are not reliably
+    // invokable via click()/toggle() in this harness. Prefer firing clicked(),
+    // then fall back to pointer synthesis.
+    if (item && (class_name.contains(QStringLiteral("Button_"))
+                 || class_name.contains(QStringLiteral("ActionItem_")))) {
+        if (try_emit_clicked(meta)) {
             return return_ok();
         }
         if (synthesize_click()) {
@@ -394,8 +411,7 @@ QByteArray TestBridge::cmdClick(const QString& object_name)
     }
 
     // Non-visual fall-back for plain QObject fixtures.
-    const int clicked_index = meta->indexOfSignal("clicked()");
-    if (clicked_index >= 0 && meta->method(clicked_index).invoke(obj, Qt::DirectConnection)) {
+    if (try_emit_clicked(meta)) {
         return return_ok();
     }
 
@@ -548,6 +564,19 @@ QByteArray TestBridge::cmdGetClipboardText()
     return QJsonDocument(resp).toJson(QJsonDocument::Compact);
 }
 
+QByteArray TestBridge::cmdSetClipboardText(const QString& text)
+{
+    if (QGuiApplication::clipboard() == nullptr) {
+        return errorResponse(QStringLiteral("Clipboard is unavailable"));
+    }
+
+    QGuiApplication::clipboard()->setText(text);
+
+    QJsonObject resp;
+    resp[QStringLiteral("ok")] = true;
+    return QJsonDocument(resp).toJson(QJsonDocument::Compact);
+}
+
 QByteArray TestBridge::cmdSaveScreenshot(const QString& path)
 {
     if (path.isEmpty()) {

qml/test/testbridge.h

@@ -29,6 +29,7 @@
 ///   {"cmd": "wait_for_property", "objectName": "<name>", "prop": "<property>", "timeout": <ms>, "value": <json>, "contains": "<substring>", "nonEmpty": true}
 ///   {"cmd": "get_text", "objectName": "<name>"}
 ///   {"cmd": "get_clipboard_text"}
+///   {"cmd": "set_clipboard_text", "text": "<value>"}
 ///   {"cmd": "save_screenshot", "path": "</tmp/screenshot.png>"}
 ///   {"cmd": "list_objects"}
 class TestBridge : public QObject
@@ -71,6 +72,7 @@ private Q_SLOTS:
     QByteArray cmdWaitForProperty(const QString& object_name, const QString& prop, int timeout_ms, const QJsonValue& expected, bool has_expected, const QString& contains, bool non_empty);
     QByteArray cmdGetText(const QString& object_name);
     QByteArray cmdGetClipboardText();
+    QByteArray cmdSetClipboardText(const QString& text);
     QByteArray cmdSaveScreenshot(const QString& path);
     QByteArray cmdListObjects();
 

test/functional/qml_driver.py

@@ -166,6 +166,12 @@ def get_clipboard_text(self):
             raise QmlDriverError(f"get_clipboard_text() failed: {resp['error']}")
         return resp["text"]
 
+    def set_clipboard_text(self, text):
+        """Set clipboard text inside the GUI process."""
+        resp = self._send({"cmd": "set_clipboard_text", "text": text})
+        if "error" in resp:
+            raise QmlDriverError(f"set_clipboard_text() failed: {resp['error']}")
+
     def save_screenshot(self, path):
         """Capture the GUI window and save it as a PNG file."""
         resp = self._send({"cmd": "save_screenshot", "path": path})