diff --git a/docs/migrations/v0.18/changeset-form.md b/docs/migrations/v0.18/changeset-form.md index df1222e00..803bcd1b9 100644 --- a/docs/migrations/v0.18/changeset-form.md +++ b/docs/migrations/v0.18/changeset-form.md @@ -279,7 +279,6 @@ Key changes: manual binding and Select key-based selection. ```typescript import Component from '@glimmer/component'; import { tracked } from '@glimmer/tracking'; -import { action } from '@ember/object'; export default class ChangesetFormComponent extends Component { @tracked hasSubmitted = false; @@ -296,25 +295,22 @@ export default class ChangesetFormComponent extends Component { { key: 'ca', label: 'Canada' } ]; - @action - updateField(changeset, fieldName, value) { + updateField = (changeset, fieldName, value) => { changeset.set(fieldName, value); changeset.validate(fieldName); - } + }; // Select components use keys, need conversion for changeset - @action - updateCountry(changeset, selectedKey) { + updateCountry = (changeset, selectedKey) => { changeset.set('country', selectedKey); changeset.validate('country'); - } + }; getSelectedCountry(changeset) { return changeset.get('country') || null; } - @action - async handleSubmit(changeset, event) { + handleSubmit = async (changeset, event) => { event.preventDefault(); await changeset.validate(); this.hasSubmitted = true; @@ -322,7 +318,7 @@ export default class ChangesetFormComponent extends Component { if (changeset.isValid) { await changeset.save({}); } - } + }; getFieldErrors(changeset, fieldName) { if (!this.hasSubmitted) return []; diff --git a/docs/theming/configuration/theme-switching.md b/docs/theming/configuration/theme-switching.md index 69e01d698..1a7d8af55 100644 --- a/docs/theming/configuration/theme-switching.md +++ b/docs/theming/configuration/theme-switching.md @@ -38,7 +38,6 @@ fight this site's own theme switcher. ```gts import Component from '@glimmer/component'; import { tracked } from '@glimmer/tracking'; -import { action } from '@ember/object'; import { Button } from 'frontile'; export default class ThemeToggle extends Component { @@ -54,12 +53,11 @@ export default class ThemeToggle extends Component { this.applyTheme(); } - @action - toggleTheme(): void { + toggleTheme = (): void => { this.isDark = !this.isDark; this.applyTheme(); localStorage.setItem('theme', this.isDark ? 'dark' : 'light'); - } + }; applyTheme(): void { const html = document.documentElement; diff --git a/packages/changeset-form/src/components/changeset-form/fields/base.ts b/packages/changeset-form/src/components/changeset-form/fields/base.ts index d8dd35a76..24dc60f62 100644 --- a/packages/changeset-form/src/components/changeset-form/fields/base.ts +++ b/packages/changeset-form/src/components/changeset-form/fields/base.ts @@ -1,7 +1,6 @@ import Component from '@glimmer/component'; import type { BufferedChangeset } from 'ember-changeset/types'; import { assert } from '@ember/debug'; -import { action } from '@ember/object'; import { later } from '@ember/runloop'; import type Owner from '@ember/owner'; @@ -66,8 +65,7 @@ export default class ChangesetFormFieldsBase< }, []); } - @action - async validate(): Promise { + validate = async (): Promise => { later( this, () => { @@ -75,5 +73,5 @@ export default class ChangesetFormFieldsBase< }, 1 ); - } + }; } diff --git a/packages/changeset-form/src/components/changeset-form/fields/checkbox-group.gts b/packages/changeset-form/src/components/changeset-form/fields/checkbox-group.gts index 86ffa8957..94bee54f2 100644 --- a/packages/changeset-form/src/components/changeset-form/fields/checkbox-group.gts +++ b/packages/changeset-form/src/components/changeset-form/fields/checkbox-group.gts @@ -1,6 +1,5 @@ import Component from '@glimmer/component'; import { assert } from '@ember/debug'; -import { action } from '@ember/object'; import ChangesetFormFieldsCheckbox from './checkbox'; import FormCheckboxGroup, { type FormCheckboxGroupArgs @@ -70,19 +69,19 @@ export default class ChangesetFormFieldsCheckboxGroup extends Component { + validate = async (): Promise => { if (this.args.groupName) { await this.args.changeset.validate(this.args.groupName); } - } + }; - @action handleChange(value: unknown, event: Event): void { + handleChange = (value: unknown, event: Event): void => { this.validate(); if (typeof this.args.onChange === 'function') { this.args.onChange(value, event); } - } + };