Raising events asynchronously is objectively the right approach for nearly everything, so it should be the default. I never intended for this setting to stay around long term, so now that the experiment has concluded, it can be removed from the options.
I could leave it in place, default the static property on SoulseekClient to true, and then allow a consumer to set that property to false if they needed to; the option would be there but not a documented part of the configuration API. This means all of the associated if/else logic needs to stay, and I'm not sure I want that to be the case.
Raising events asynchronously is objectively the right approach for nearly everything, so it should be the default. I never intended for this setting to stay around long term, so now that the experiment has concluded, it can be removed from the options.
I could leave it in place, default the static property on
SoulseekClientto true, and then allow a consumer to set that property to false if they needed to; the option would be there but not a documented part of the configuration API. This means all of the associated if/else logic needs to stay, and I'm not sure I want that to be the case.