Post go fix

Author: jphsd

image.go

@@ -118,35 +118,35 @@ func (f *Image) biPatch(u, v float64, p [][]tcol.FRGBA) tcol.FRGBA {
 	col := make([]float64, 4)
 
 	// R
-	for j := 0; j < 4; j++ {
-		for i := 0; i < 4; i++ {
+	for j := range 4 {
+		for i := range 4 {
 			col[i] = p[i][j].R
 		}
 		row[j] = bcclamp(f.interp(v, col))
 	}
 	r := bcclamp(f.interp(u, row))
 
 	// G
-	for j := 0; j < 4; j++ {
-		for i := 0; i < 4; i++ {
+	for j := range 4 {
+		for i := range 4 {
 			col[i] = p[i][j].G
 		}
 		row[j] = bcclamp(Cubic(v, col))
 	}
 	g := bcclamp(f.interp(u, row))
 
 	// B
-	for j := 0; j < 4; j++ {
-		for i := 0; i < 4; i++ {
+	for j := range 4 {
+		for i := range 4 {
 			col[i] = p[i][j].B
 		}
 		row[j] = bcclamp(f.interp(v, col))
 	}
 	b := bcclamp(f.interp(u, row))
 
 	// A
-	for j := 0; j < 4; j++ {
-		for i := 0; i < 4; i++ {
+	for j := range 4 {
+		for i := range 4 {
 			col[i] = p[i][j].A
 		}
 		row[j] = bcclamp(f.interp(v, col))

perlin.go

@@ -20,15 +20,15 @@ func NewPerlin(seed int64) *Perlin {
 	res.Seed = seed
 
 	// Initialize hash
-	for i := 0; i < 256; i++ {
+	for i := range 256 {
 		res.ph[i] = uint8(i)
 	}
 
 	lr := rand.New(rand.NewSource(seed))
 	// Scramble hash
 	lr.Shuffle(256, func(i, j int) { res.ph[i], res.ph[j] = res.ph[j], res.ph[i] })
 	// And replicate
-	for i := 0; i < 256; i++ {
+	for i := range 256 {
 		res.ph[i+256] = res.ph[i]
 	}
 

points.go

@@ -62,10 +62,7 @@ func NewWorleyField(points [][]float64, a, b []float64,
 	scale, offset float64) *WorleyField {
 	kdtree := datastruct.NewKDTree(2, points...)
 	kdtree.Dist = d
-	np := len(b)
-	if np > len(points) {
-		np = len(points)
-	}
+	np := min(len(b), len(points))
 	return &WorleyField{"WorleyField", points, a, b, f, scale, offset, kdtree, np}
 }
 

random/wave.go

@@ -18,7 +18,7 @@ func MakePatternWave() texture.Wave {
 	nl := rand.Intn(5) + 1
 	lambdas := make([]float64, nl)
 	patterns := make([][]float64, nl)
-	for i := 0; i < nl; i++ {
+	for i := range nl {
 		lambdas[i] = PickLambda()
 		patterns[i] = MakePattern(5)
 	}
@@ -27,7 +27,7 @@ func MakePatternWave() texture.Wave {
 
 func MakePattern(n int) []float64 {
 	pat := make([]float64, n)
-	for i := 0; i < n; i++ {
+	for i := range n {
 		pat[i] = rand.Float64()*2 - 1
 	}
 	return pat
@@ -38,7 +38,7 @@ func MakeNLWave() texture.Wave {
 	nl := rand.Intn(5) + 1
 	lambdas := make([]float64, nl)
 	nlfs := make([]*texture.NonLinear, nl)
-	for i := 0; i < nl; i++ {
+	for i := range nl {
 		lambdas[i] = PickLambda()
 		nlfs[i] = MakeNL()
 	}

wave.go

@@ -217,7 +217,7 @@ func NewACWave(lambdas []float64, nlfs []*NonLinear, once bool) *ACWave {
 		res.Lambdas[3] = lambdas[3]
 	}
 	sum := 0.0
-	for i := 0; i < 4; i++ {
+	for i := range 4 {
 		sum += res.Lambdas[i]
 		res.CumLambda[i] = sum
 	}