FLET setf function

[kchanqvq]

Another root of evil:

CL-USER> (flet (((setf foo) (new-val x) (setf (car x) new-val)))
|         (setf (foo (cons 1 2)) 3))
SIMPLE-ERROR: Unknown generalized reference.
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:43834:7
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:43837:3
    at internals.Symbol.JSCL_USER_ERROR [as fvalue] (/home/kchan/quicklisp/local-projects/jscl/jscl.js:43838:3)
    at JSCL_USER_NIL (/home/kchan/quicklisp/local-projects/jscl/jscl.js:1320:53)
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:1328:13
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:1329:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:1330:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:1331:3
    at internals.Symbol.JSCL_USER_GETSETFEXPANSION [as fvalue] (/home/kchan/quicklisp/local-projects/jscl/jscl.js:1332:3)
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:60126:9
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:60130:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:60131:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:60132:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:60142:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:60143:3
    at JSCL_USER_NIL (/home/kchan/quicklisp/local-projects/jscl/jscl.js:60144:3)
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:37318:42
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:37319:3
    at /home/kchan/quicklisp/local-projects/jscl/jscl.js:37320:3
    at internals.bindSpecialBindings (/home/kchan/quicklisp/local-projects/jscl/jscl.js:388:12)
... 99 more frames, increase JSCL::*BACKTRACE-LIMIT* to view more

In SBCL:

CL-USER> (flet (((setf foo) (new-val x) (setf (car x) new-val)))
        (setf (foo (cons 1 2)) 3))
3

[kchanqvq]

To fix this we'll have to accept "function names" (either symbol or (setf <symbol>)) for places where we assumed to be symbol.

It's not that difficult, but one consequence is we'll need to use a lot more equal test (for find etc) instead of eql.

[kchanqvq]

This is wrong as well:

CL-USER> (fdefinition #'car)
#<FUNCTION CAR>

This should throws an error. On SBCL:

JSCL> (fdefinition #'car)
; Evaluation aborted on #<SIMPLE-TYPE-ERROR expected-type: SB-IMPL::FUNCTION-NAME
;                     datum: #<FUNCTION CAR>>.

[kchanqvq]

CL-USER> #'(setf car)
SIMPLE-ERROR: NIL is not defined