Sync dev with master#4
Merged
Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.9.4 → v0.9.9](astral-sh/ruff-pre-commit@v0.9.4...v0.9.9) - [github.com/crate-ci/typos: v1.29.5 → v1.30.0](crate-ci/typos@v1.29.5...v1.30.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* fix timing check for adc delay * split rf and adc case again and add comment --------- Co-authored-by: Patrick Schuenke <37338697+schuenke@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.9.9 → v0.11.4](astral-sh/ruff-pre-commit@v0.9.9...v0.11.4) - [github.com/crate-ci/typos: v1.30.0 → v1](crate-ci/typos@v1.30.0...v1)
Add convert_to_arbitrary option to make_extended_trapezoid_area function
…rk#270) * - when checked for system violations of sequence, floating point accuracy is considered * - changed >= to > - added eps to avoid floating point rounding issues --------- Co-authored-by: Patrick Schuenke <37338697+schuenke@users.noreply.github.com>
…-update-config [pre-commit] pre-commit autoupdate
* - fix label plot error for seq.plot(label='SLC') * Revert "- fix label plot error for seq.plot(label='SLC')" This reverts commit 2408231. * - fix if clause for plotting labels from 'p' to 'list(p)' --------- Co-authored-by: Bilal Taşdelen <tasdelen@usc.edu>
- add license badge - add python version badge - add infos about Pulse 1.5.0 support - update default branch from 'dev' to 'master' - add 'use' argument in example code
…ath-patch-1 Update README.md with FAIR checklist, Python and License badges
Had a typo in np.arange on line 258
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.4 → v0.11.8](astral-sh/ruff-pre-commit@v0.11.4...v0.11.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ath-patch-1 Update write_t2_se.ipynb
* add interpolation for block pulses with freq offset * adjust plot of rf pulses to match MATLAB version
…framework#283) * fix get_gradients function for channel specific gradient delays * Update docstrings
* fixes timing of GRE sequences if rf.ringdown_time gets larger then gz.fall_time * - fixes TE time issue without assuming that the center of the RF pulse is in the center of the waveform * - replace reference write_gre.seq due to previous rounding issue in calculation of delay_TE. delay_TE is now 81 ms instead of 82 ms. * - remove FOV and name from header of reference sequence
updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.8 → v0.11.12](astral-sh/ruff-pre-commit@v0.11.8...v0.11.12)
Add missing ACQ label in supported_labels()
* [pre-commit] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.11.12 → v0.12.7](astral-sh/ruff-pre-commit@v0.11.12...v0.12.7) * fix RUF005: replace concatenation with iterable unpacking --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Patrick Schuenke <patrick.schuenke@nvision-imaging.com>
* [pre-commit] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.12.7 → v0.12.11](astral-sh/ruff-pre-commit@v0.12.7...v0.12.11) * Change min Python version to 3.9 * Change typos version. * Change typos version. * Revert min python version. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bilal Taşdelen <bilaltasdelen@windowslive.com>
* Add github action to codespell master on push and PRs * Add rudimentary codespell config * Add pre-commit definition for codespell --------- Co-authored-by: Patrick Schuenke <37338697+schuenke@users.noreply.github.com>
* Fix grad raster time typo. Make system rasters consistent with the defs. * Add doc build requirements as optional requirements and remove separate req file. * Revert "Fix grad raster time typo. Make system rasters consistent with the defs." This reverts commit 3745bc1.
…#313) * [pre-commit] pre-commit autoupdate * push typos and ruff version * fix RUF043 errors * fix B905 and RUF059 errors * fix codespell pre-commit config --------- Co-authored-by: Patrick Schuenke <patrick.schuenke@nvision-imaging.com>
…ework#310) * ignore adc events prior to rf in test report * add seq5 as another test sequence including preceding noise acquisition --------- Co-authored-by: Patrick Schuenke <37338697+schuenke@users.noreply.github.com> Co-authored-by: Patrick Schuenke <patrick.schuenke@nvision-imaging.com>
Add comprehensive soft delay functionality for enhanced sequence timing control and file format 1.5.0 support. Key Features: - Soft delay blocks: Create timing placeholders with `pp.make_soft_delay(hint, default_duration)` - Automatic numID assignment: Simplified API with optional manual ID specification - File format compatibility: Full read/write support for .seq files with soft delays - Sequence plotting: Visual representation of soft delays in RF phase subplot - Timing validation: Enhanced check_timing() with soft delay awareness Implementation Details: - Complete API with `make_soft_delay()`, `register_soft_delay_event()`, and `apply_soft_delay()` - Robust parameter validation including all whitespace types - Automatic duration handling with configurable defaults - Integration with existing sequence building workflow - Backward compatibility with existing sequences Testing & Documentation: - 14 comprehensive test functions covering edge cases and boundary conditions - Complete docstrings with mathematical explanations and practical examples - Simple beginner example demonstrating basic soft delay usage - Enhanced documentation for complex timing scenarios --------- Co-authored-by: Matteo Cencini <matteo.cencini@gmail.com> Co-authored-by: Patrick Schuenke <patrick.schuenke@nvision-imaging.com>
* fix mod_grad_axis method - fixed tuple conversion - updated to new EventLibrary structure - added automatic cache clearing (important!) - updated documentation and type annotation - added empty sequence handling - added comprehensive tests for all cases * use EventLibrary.update()
* [pre-commit] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.0 → v0.14.3](astral-sh/ruff-pre-commit@v0.14.0...v0.14.3) - [github.com/crate-ci/typos: v1.38.1 → v1.39.0](crate-ci/typos@v1.38.1...v1.39.0) * manually adjust typos version --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Patrick Schuenke <37338697+schuenke@users.noreply.github.com>
Synch master with dev branch
Sync master branch with imp-framework fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.