Thanks for creating this! PR'ing back a bunch of improvements I made #8
Replies: 1 comment
|
Thanks for this, and sorry it sat so long — all seven are merged. They were good PRs. The Bluetooth one in particular: I landed a large change to the CI/CD widget just before yours, so a few needed conflict resolution. I did that here rather than sending them back to you — the work was already done and you had waited long enough. Your commits went in unchanged where they applied cleanly, with any follow-up as a separate commit on top. Three that came in with adjustments: #4 and #7 landed without a call site or without UI. #6 I made optional. The gap is real — in kiosk mode there is genuinely no path to Settings or a clean quit — but #5 I took two of three. I dropped One small thing: the dispatch queue in #1 was labelled If you are running this on an Edge daily, you are hitting things I never will — the sleep/wake behaviour in #3 is a good example. More of these are very welcome. There is a short section in CONTRIBUTING now on running the test suite, which until recently could not run at all. |
Uh oh!
There was an error while loading. Please reload this page.
Hey @kemalandic, first off thank you for creating this! I just picked up a Corsair Xeneon Edge myself and was looking to get it up and running on macOS. Your repo was a huge jumpstart for me in building myself a bunch of dashboards.
I've PR'ed back a bunch of fixes/improvements:
All reactions