Skip to content

timeUntil a timestamp in the future says '... ago' #3

Description

@lesiki

Hi there,

This may just be poor understanding on my behalf, but it looks to me like the timeUntil function handles things a bit strangely: a timestamp 1 day in the future gives "one day ago", and a timestamp one day in the past gives "a day from now". My intuitive understanding would expect these the other way round.

This is shown in the example from the readme:

String hours = time.timeUntil(current - (6 * 60 * 60 * 1000));  // returns "6 hours from now"

Surely you'd expect "6 hours from now" when you provide a time that is 6 hours in the future, not the past?

If I'm correct, I think the fix would be to check for distanceInMilis being positive instead of negative on this line.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions