mentioned in: bitcoin#35730
bitcoin#35730 (review)
"cr ACK 779e722
LGTM!
During review I discovered that ClientAllowed() does not actively disconnects the client, but awaits the timeout / disconnect from the client. The current PR limits the number of active connections which makes waiting for timeouts / client disconnects a (increased) DDOS vector, I have created a followup PR bitcoin#35772 to address this. bitcoin#35592 will mitigate the issue." - janb84
mentioned in: bitcoin#35730
bitcoin#35730 (review)
"cr ACK 779e722
LGTM!
During review I discovered that
ClientAllowed()does not actively disconnects the client, but awaits the timeout / disconnect from the client. The current PR limits the number of active connections which makes waiting for timeouts / client disconnects a (increased) DDOS vector,I have created a followup PR bitcoin#35772 to address this.bitcoin#35592 will mitigate the issue." - janb84