refactor: update cookie options to use storageSettings for maxCookieLength: Daniel feedback

Author: dtoxvanilla1991

lib/main.ts

@@ -26,7 +26,7 @@ export {
   isServer,
   getCookieOptions,
 } from "./utils";
-export type { CookieOptions, CookieOptionValue } from "./utils";
+export type { CookieOptions } from "./utils";
 
 export {
   getClaim,

lib/utils/getCookieOptions.test.ts

@@ -3,17 +3,17 @@ import { describe, it, expect } from "vitest";
 import {
   getCookieOptions,
   TWENTY_NINE_DAYS,
-  MAX_COOKIE_LENGTH,
   GLOBAL_COOKIE_OPTIONS,
 } from "./getCookieOptions";
+import { storageSettings } from "../sessionManager/index";
 
 describe("getCookieOptions", () => {
   it("returns the default configuration when no options provided", () => {
     const result = getCookieOptions();
 
     expect(result).toMatchObject({
       maxAge: TWENTY_NINE_DAYS,
-      maxCookieLength: MAX_COOKIE_LENGTH,
+      maxCookieLength: storageSettings.maxLength,
       sameSite: "lax",
       httpOnly: true,
       path: "/",
@@ -27,15 +27,13 @@ describe("getCookieOptions", () => {
       path: "/custom",
       maxAge: 60,
       domain: "example.com",
-      customOption: "value",
     });
 
     expect(result.secure).toBe(true);
     expect(result.sameSite).toBe("none");
     expect(result.path).toBe("/custom");
     expect(result.maxAge).toBe(60);
     expect(result.domain).toBe("example.com");
-    expect(result.customOption).toBe("value");
   });
 
   it("preserves GLOBAL_COOKIE_OPTIONS when not overridden", () => {
@@ -61,16 +59,6 @@ describe("getCookieOptions", () => {
     expect(result.sameSite).toBe("lax");
     expect(result.path).toBe("/");
   });
-
-  it("supports custom passthrough options", () => {
-    const result = getCookieOptions({
-      customFlag: true,
-      anotherOption: "test",
-    });
-
-    expect(result.customFlag).toBe(true);
-    expect(result.anotherOption).toBe("test");
-  });
 });
 
 describe("GLOBAL_COOKIE_OPTIONS", () => {
@@ -79,6 +67,6 @@ describe("GLOBAL_COOKIE_OPTIONS", () => {
     expect(GLOBAL_COOKIE_OPTIONS.sameSite).toBe("lax");
     expect(GLOBAL_COOKIE_OPTIONS.path).toBe("/");
     expect(GLOBAL_COOKIE_OPTIONS.maxAge).toBe(TWENTY_NINE_DAYS);
-    expect(GLOBAL_COOKIE_OPTIONS.maxCookieLength).toBe(MAX_COOKIE_LENGTH);
+    expect(GLOBAL_COOKIE_OPTIONS.maxCookieLength).toBe(storageSettings.maxLength);
   });
 });

lib/utils/getCookieOptions.ts

@@ -1,4 +1,4 @@
-export type CookieOptionValue = string | number | boolean | undefined;
+import { storageSettings } from "../sessionManager/index.js";
 
 export interface CookieOptions {
   maxAge?: number;
@@ -8,11 +8,9 @@ export interface CookieOptions {
   httpOnly?: boolean;
   secure?: boolean;
   path?: string;
-  [key: string]: CookieOptionValue;
 }
 
 export const TWENTY_NINE_DAYS = 2505600;
-export const MAX_COOKIE_LENGTH = 3000;
 
 /**
  * Default cookie options used across Kinde SDKs.
@@ -27,7 +25,7 @@ export const MAX_COOKIE_LENGTH = 3000;
  */
 export const GLOBAL_COOKIE_OPTIONS: CookieOptions = {
   maxAge: TWENTY_NINE_DAYS,
-  maxCookieLength: MAX_COOKIE_LENGTH,
+  maxCookieLength: storageSettings.maxLength,
   sameSite: "lax",
   httpOnly: true,
   path: "/",

lib/utils/index.ts

@@ -10,7 +10,7 @@ export {
   generateKindeSDKHeader,
 } from "./exchangeAuthCode";
 export { getCookieOptions } from "./getCookieOptions";
-export type { CookieOptions, CookieOptionValue } from "./getCookieOptions";
+export type { CookieOptions } from "./getCookieOptions";
 export { checkAuth } from "./checkAuth";
 export { isCustomDomain } from "./isCustomDomain";
 export { setRefreshTimer, clearRefreshTimer } from "./refreshTimer";