Observation
Found while addressing review feedback on #326.
docs/SERVER.md:32 documents a lora_adapter request field. Grep puts it nowhere in
src/DotLLM.Server/ — not in the Anthropic DTOs, and not in the OpenAI ones either. The doc frames
it as parity with the OpenAI surface, so the claim is wrong twice over: the field is unimplemented,
and the surface it claims parity with does not have it.
A user sending lora_adapter today gets it silently ignored, with no error and no effect — the
worst outcome for a field that appears in the documentation.
LoRA is not implemented anywhere in the server. Across the tree it exists only as
src/DotLLM.Engine/IAdapterManager.cs — an interface with no implementations and no references —
plus InferenceRequest.AdapterId. It is roadmap step 47, unstarted. (An earlier revision of this
issue claimed a registry and admin endpoints existed; that was wrong, and corrected here.)
Options
Either is fine, but the current state should not persist:
- Remove it from the docs and note that per-request adapter selection is not yet supported,
pointing at the admin endpoints for what does work. Smallest, honest.
- Implement it — wire the field through the request DTOs to adapter selection. Larger, and
wants its own design discussion about precedence when an adapter is also set server-side.
I would do (1) now and open (2) separately if per-request selection is wanted, so the docs stop
describing something that does not exist in the meantime.
Acceptance criteria
References
Observation
Found while addressing review feedback on #326.
docs/SERVER.md:32documents alora_adapterrequest field. Grep puts it nowhere insrc/DotLLM.Server/— not in the Anthropic DTOs, and not in the OpenAI ones either. The doc framesit as parity with the OpenAI surface, so the claim is wrong twice over: the field is unimplemented,
and the surface it claims parity with does not have it.
A user sending
lora_adaptertoday gets it silently ignored, with no error and no effect — theworst outcome for a field that appears in the documentation.
LoRA is not implemented anywhere in the server. Across the tree it exists only as
src/DotLLM.Engine/IAdapterManager.cs— an interface with no implementations and no references —plus
InferenceRequest.AdapterId. It is roadmap step 47, unstarted. (An earlier revision of thisissue claimed a registry and admin endpoints existed; that was wrong, and corrected here.)
Options
Either is fine, but the current state should not persist:
pointing at the admin endpoints for what does work. Smallest, honest.
wants its own design discussion about precedence when an adapter is also set server-side.
I would do (1) now and open (2) separately if per-request selection is wanted, so the docs stop
describing something that does not exist in the meantime.
Acceptance criteria
docs/SERVER.mdno longer documents a request field that does not exist, or the field isimplemented and covered by a test.
References
/v1/messagesexample; this issue coversdocs/SERVER.md, which that PR does not touch