not able to change canonical name label

[henrysecond1]

Some apps like kiali use service.istio.io/canonical-name, canonical-revision labels, so we want to manually set the labels.
However, we were not able to set them because the net-istio webhook forcefully set these labels.

• https://github.com/knative-sandbox/net-istio/blob/release-1.7/pkg/defaults/deployment_defaults.go#L69-L80

Can we set labels only if the users do not specify them?

[nak3]

Can we set labels only if the users do not specify them?

Yes, I think it is no problem to change the webhook as you said. What do you think @AngeloDanducci

[AngeloDanducci]

I'm always in favor of more freedom of configuration as long as the defaults are good 👍

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[knative-prow-robot]

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close

/lifecycle stale