-
Notifications
You must be signed in to change notification settings - Fork 107
Unused ClusterRole knative-serving-istio #995
Copy link
Copy link
Open
Labels
kind/enhancementlifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.triage/acceptedIssues which should be fixed (post-triage)Issues which should be fixed (post-triage)
Metadata
Metadata
Assignees
Labels
kind/enhancementlifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.triage/acceptedIssues which should be fixed (post-triage)Issues which should be fixed (post-triage)
Type
Fields
Give feedbackNo fields configured for issues without a type.
ClusterRole
knative-serving-istioseems to not be binding to any RoleBinding/ClusterRoleBindings.https://github.com/knative-sandbox/net-istio/blob/main/config/200-clusterrole.yaml
net-istio-controllerDeployment is using the ServiceAccountcontrollerwhich is used by the knative-serving Controller. This ServiceAccount already has the following permissions from ClusterRoleknative-serving-adminIt would be ideal for net-istio-controller to use its own ServiceAccount with its own permissions and follow the principle of least privilege