chore(lint): lint/formatted codebase

Author: bashandbone

.serena/project.yml

@@ -130,3 +130,8 @@ language_backend:
 # list of regex patterns which, when matched, mark a memory entry as read‑only.
 # Extends the list from the global configuration, merging the two lists.
 read_only_memory_patterns: []
+
+# line ending convention to use when writing source files.
+# Possible values: unset (use global setting), "lf", "crlf", or "native" (platform default)
+# This does not affect Serena's own files (e.g. memories and configuration files), which always use native line endings.
+line_ending:

src/exportify/commands/sync.py

@@ -22,6 +22,7 @@
 from exportify.commands.utils import (
     CONSOLE,
     collect_py_files,
+    display_path,
     get_all_source_roots,
     load_config_and_rules,
     path_to_module,
@@ -76,7 +77,7 @@ def _print_sync_results(result: ExportGenerationResult) -> None:
 
 def _report_module_all_dry_run(py_file: Path, result: ModuleAllFixResult) -> None:
     """Print dry-run diff for a single module __all__ fix."""
-    print_info(f"Would update {py_file}")
+    print_info(f"Would update {display_path(py_file)}")
     if result.added:
         CONSOLE.print(f"  [green]+[/green] Add to __all__: {result.added}")
     if result.removed:
@@ -87,7 +88,7 @@ def _report_module_all_dry_run(py_file: Path, result: ModuleAllFixResult) -> Non
 
 def _report_module_all_applied(py_file: Path, result: ModuleAllFixResult, *, verbose: bool) -> None:
     """Print applied-fix info for a single module __all__ fix."""
-    print_success(f"Updated {py_file}")
+    print_success(f"Updated {display_path(py_file)}")
     if not verbose:
         return
     if result.added:

src/exportify/commands/utils.py

@@ -15,7 +15,7 @@
 from exportify.common.config import CONFIG_ENV_VAR, ExportifyConfig, find_config_file, load_config
 from exportify.export_manager import RuleEngine
 from exportify.types import ValidationReport
-from exportify.utils import detect_source_root, locate_project_root
+from exportify.utils import detect_source_root, display_path, locate_project_root
 
 
 logger = logging.getLogger(__name__)
@@ -46,12 +46,14 @@ def resolve_checks(all_checks: set[str], **flags: bool | None) -> set[str]:
 
 def get_all_source_roots(source_override: Path | None = None) -> list[Path]:
     """Get all source roots: primary (detected or overridden) + additional from config."""
-    source_root = source_override or detect_source_root()
+    source_root = (source_override or detect_source_root()).resolve()
     additional_source_roots: list[Path] = []
 
     if config_path := find_config_file():
         config = load_config(config_path)
-        additional_source_roots = config.project.additional_source_paths
+        additional_source_roots = [
+            Path(p).resolve() for p in config.project.additional_source_paths
+        ]
 
     return [source_root, *additional_source_roots]
 
@@ -206,15 +208,23 @@ def print_output_validation_verbose(results: ValidationReport) -> None:
         CONSOLE.print(f"[red]Errors found: {len(results.errors)}[/red]")
         CONSOLE.print()
         for error in results.errors:
-            location = f"{error.file}:{error.line}" if error.line else str(error.file)
+            location = (
+                f"{display_path(error.file)}:{error.line}"
+                if error.line
+                else display_path(error.file)
+            )
             CONSOLE.print(f"[red]ERROR[/red] {location}: [bold]{error.code}[/bold]")
             _print_error_in_validation(error)
     # Show warnings with full context
     if results.warnings:
         CONSOLE.print(f"[yellow]Warnings found: {len(results.warnings)}[/yellow]")
         CONSOLE.print()
         for warning in results.warnings:
-            location = f"{warning.file}:{warning.line}" if warning.line else str(warning.file)
+            location = (
+                f"{display_path(warning.file)}:{warning.line}"
+                if warning.line
+                else display_path(warning.file)
+            )
             CONSOLE.print(f"[yellow]WARNING[/yellow] {location}")
             _print_error_in_validation(warning)
     # Show metrics
@@ -231,12 +241,20 @@ def print_output_validation_concise(results: ValidationReport) -> None:
     """Output validation results in concise human-readable format."""
     if results.errors:
         for error in results.errors:
-            location = f"{error.file}:{error.line}" if error.line else str(error.file)
+            location = (
+                f"{display_path(error.file)}:{error.line}"
+                if error.line
+                else display_path(error.file)
+            )
             CONSOLE.print(f"[red][ERROR][/red] {location}: {error.code} ({error.message})")
 
     if results.warnings:
         for warning in results.warnings:
-            location = f"{warning.file}:{warning.line}" if warning.line else str(warning.file)
+            location = (
+                f"{display_path(warning.file)}:{warning.line}"
+                if warning.line
+                else display_path(warning.file)
+            )
             CONSOLE.print(f"[yellow][WARNING][/yellow] {location}: {warning.message}")
 
     # Show summary
@@ -261,19 +279,23 @@ def collect_py_files(paths: tuple[Path, ...], source: Path | None) -> list[Path]
     Returns:
         List of Python file paths to process.
     """
+    from exportify.discovery.file_discovery import FileDiscovery
+
+    discovery = FileDiscovery()
+
     if not paths:
         source_root = source or detect_source_root()
-        return list(source_root.rglob("*.py"))
+        return discovery.discover_python_files(source_root)
 
     all_files: list[Path] = []
     for p in paths:
         if not p.exists():
             print_error(f"Path does not exist: {p}")
             raise SystemExit(1)
         if p.is_file():
-            all_files.append(p)
+            all_files.append(p.resolve())
         else:
-            all_files.extend(p.rglob("*.py"))
+            all_files.extend(discovery.discover_python_files(p.resolve()))
     return all_files
 
 

src/exportify/discovery/file_discovery.py

@@ -62,10 +62,25 @@ def discover_python_files(
 
         python_files = []
 
+        # Common directories to always skip
+        skip_dirs = {
+            "__pycache__",
+            ".venv",
+            "venv",
+            ".git",
+            ".hg",
+            ".mypy_cache",
+            ".pytest_cache",
+            ".ruff_cache",
+            "build",
+            "dist",
+            "node_modules",
+        }
+
         # Use rglob to recursively find all .py files
         for py_file in root.rglob("*.py"):
-            # Skip __pycache__ directories
-            if "__pycache__" in py_file.parts:
+            # Skip common directories
+            if any(d in py_file.parts for d in skip_dirs):
                 continue
 
             # Skip if gitignored

src/exportify/export_manager/module_all.py

@@ -28,6 +28,7 @@
 from exportify.analysis.ast_parser import ASTParser
 from exportify.common.types import RuleAction, SymbolProvenance
 from exportify.export_manager.rules import RuleEngine
+from exportify.utils import display_path
 
 
 # ---------------------------------------------------------------------------
@@ -331,7 +332,7 @@ def check_module_all(file: Path, module_path: str, rules: RuleEngine) -> list[Mo
                 issue_type="no_all",
                 symbol_name="",
                 message=(
-                    f"{file}: __all__ is absent but {len(should_export)} export(s) "
+                    f"{display_path(file)}: __all__ is absent but {len(should_export)} export(s) "
                     f"are prescribed by rules: {sorted(should_export)}"
                 ),
             )
@@ -344,7 +345,7 @@ def check_module_all(file: Path, module_path: str, rules: RuleEngine) -> list[Mo
             issue_type="missing",
             symbol_name=name,
             message=(
-                f"{file}: '{name}' should be in __all__ (rules prescribe INCLUDE) but is absent"
+                f"{display_path(file)}: '{name}' should be in __all__ (rules prescribe INCLUDE) but is absent"
             ),
         )
         for name in sorted(should_export - actual)
@@ -355,7 +356,7 @@ def check_module_all(file: Path, module_path: str, rules: RuleEngine) -> list[Mo
             file=file,
             issue_type="extra",
             symbol_name=name,
-            message=(f"{file}: '{name}' is in __all__ but rules say EXCLUDE"),
+            message=(f"{display_path(file)}: '{name}' is in __all__ but rules say EXCLUDE"),
         )
         for name in sorted(actual & should_exclude)
     )

src/exportify/utils.py

@@ -316,6 +316,16 @@ def write_gitignore_patterns(exportify_dir: Path | None = None) -> None:
         gitignore_path.write_text("\n".join(gitignore_patterns) + "\n")
 
 
+def display_path(path: Path) -> str:
+    """Format a path for display, relative to CWD if possible."""
+    try:
+        # We use resolve() on CWD to ensure we're comparing absolute paths
+        # since 'path' is usually resolved.
+        return str(path.relative_to(Path.cwd().resolve()))
+    except ValueError:
+        return str(path)
+
+
 def find_project_name() -> str:
     """Find the project name from pyproject.toml or fallback to directory name."""
     if (data := _read_pyproject()) and (name := data.get("project", {}).get("name")):

src/exportify/validator/validator.py

@@ -308,7 +308,9 @@ def validate(self, file_paths: list[Path] | None = None) -> ValidationReport:
 
         for init_file in init_files:
             tree = parsed_trees.get(init_file)
-            consistency_issues = self.consistency_checker.check_file_consistency(init_file, tree=tree)
+            consistency_issues = self.consistency_checker.check_file_consistency(
+                init_file, tree=tree
+            )
             consistency_checks += len(consistency_issues)
 
             # Convert ConsistencyIssue to ValidationError/Warning

tests/fixtures/sample_type_aliases.py

@@ -12,21 +12,21 @@
 from __future__ import annotations
 
 from pathlib import Path
-from typing import TYPE_CHECKING, TypeAlias
+from typing import TYPE_CHECKING
 
 
 if TYPE_CHECKING:
     # Dummy usage of type aliases to keep static analyzers happy.
     test_file_path: FilePath | None = None
 
 # Pre-3.12 style type aliases (X: TypeAlias = Y)
-FilePath: TypeAlias = str | Path
-ModuleName: TypeAlias = str
-RulePattern: TypeAlias = str
-ExportName: TypeAlias = str
-ErrorMessage: TypeAlias = str
-ConfigDict: TypeAlias = dict[str, str | int | bool | list[str]]
-NamePair: TypeAlias = tuple[str, str]
+type FilePath = str | Path
+type ModuleName = str
+type RulePattern = str
+type ExportName = str
+type ErrorMessage = str
+type ConfigDict = dict[str, str | int | bool | list[str]]
+type NamePair = tuple[str, str]
 
 # Python 3.12+ style type aliases (type X = Y)
 type FileContent = str

tests/test_userspace.py

@@ -1,3 +1,7 @@
+# SPDX-FileCopyrightText: 2026 Knitli Inc.
+#
+# SPDX-License-Identifier: MIT OR Apache-2.0
+
 import ast
 import contextlib