Fix bug in resids() function for vglm models with link = "logit"

[riccim94]

There is an error when resids() function is applied to a vglm cumulative model with link = "logit" when the method is set to "latent" :
Error in if ([dist.name](http://dist.name/) == "norm") { : argument has length 0

The origin of the issue is related to the internal function sure:::getDistributionName.vglm which has this brief code:

function (object)
{
    switch(object@family@infos()$link, logit = "logis", probit = "norm",
        loglog = "gumbel", cloglog = "Gumbel", cauchit = "cauchy")
}

The problem is that now vglm object with logit link function saves it with a "logitlink" string, therefore a possible fix Is proposed

function (object)
{
    switch(object@family@infos()$link, logitlink = "logis", probit = "norm",
        loglog = "gumbel", cloglog = "Gumbel", cauchit = "cauchy")
}

[bgreenwell]

Thanks @riccim94, I see they did change that in VGAM a few versions back. For now, can you downgrade to an older version of VGAM? You can also make PR into the package if you have a fix! Otherwise I’ll try to get to it in the next week or so.

[riccim94]

Hello @bgreenwell Sorry for the late answer.
Thank you for your suggestion, for my activity downgrading VGAM package worked perfectly!
I just loaded a PR that hopefully would fix this issue. Actually, this is my first time doing this so I hope I made everything in the right way, let me know if there are other other step required.

The proposed change is minimal, but hopefully that would be enough to make the function work properly again.

[riccim94]

Dear Doctor Greenwell, thank you very much for your help, I decided to operate with the sure package using a previous version of the VGAM package. I also added a pull request to address this issue, it is very simple but I think it would solve the bug problem. Greetings Michele Ricci Il giorno mar 11 feb 2025 alle ore 18:55 Brandon Greenwell < ***@***.***> ha scritto:

…

Thanks @riccim94 <https://github.com/riccim94>, I see they did change that in VGAM a few versions back. For now, can you downgrade to an older version of VGAM? You can also make PR into the package if you have a fix! Otherwise I’ll try to get to it in the next week or so. — Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO2DCWGTYLZDJ6GYI6LKF3D2PI2SHAVCNFSM6AAAAABW5KFWHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJRGU4TOMRUG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>