Bump NlohmannJSON to version 3.12.0#130
Closed
flubshi wants to merge 1 commit into
Closed
Conversation
Member
3.12.0 does not compile on tvOS. At least the tests do not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This changes NlohmannJSON from
3.7.3to3.12.0.Reason
Compiling pvr.plutotv (latest Piers commit) with NlohmannJSON version 3.7.3 returns:
Compiling using NlohmannJSON version 3.12.0 works fine for me.
Is there a reason to use 3.7.3 instead of latest release 3.12.0?
Or can we just bump the version?
I runtime tested with 3.12.0 and everything seems to work (EPG, Channel playback).