Skip to content

Bump NlohmannJSON to version 3.12.0#130

Closed
flubshi wants to merge 1 commit into
kodi-pvr:Piersfrom
flubshi:piers/nlohmannjson_3.12.0
Closed

Bump NlohmannJSON to version 3.12.0#130
flubshi wants to merge 1 commit into
kodi-pvr:Piersfrom
flubshi:piers/nlohmannjson_3.12.0

Conversation

@flubshi
Copy link
Copy Markdown

@flubshi flubshi commented Mar 25, 2026

Changes

This changes NlohmannJSON from 3.7.3 to 3.12.0.

Reason

Compiling pvr.plutotv (latest Piers commit) with NlohmannJSON version 3.7.3 returns:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

Compiling using NlohmannJSON version 3.12.0 works fine for me.

Is there a reason to use 3.7.3 instead of latest release 3.12.0?
Or can we just bump the version?
I runtime tested with 3.12.0 and everything seems to work (EPG, Channel playback).

@ksooo
Copy link
Copy Markdown
Member

ksooo commented Mar 27, 2026

Is there a reason to use 3.7.3 instead of latest release 3.12.0?

3.12.0 does not compile on tvOS. At least the tests do not.

=> https://jenkins.kodi.tv/blue/rest/organizations/jenkins/pipelines/kodi-pvr/pipelines/pvr.plutotv/branches/PR-130/runs/1/nodes/260/log/?start=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants