Added info to README#133
Closed
Asmodasis wants to merge 1 commit into
Closed
Conversation
Updated README to reflect building procedure for Kodi version Piers.
ksooo
requested changes
Mar 31, 2026
| When building the add-on you have to use the correct branch depending on which version of Kodi you're building against. | ||
| If you want to build the add-on to be compatible with the latest kodi `master` commit, you need to checkout the branch with the current kodi codename. | ||
| Also make sure you follow this README from the branch in question. | ||
| The addon `inputstream.adaptive` must be built at the same time. Also make sure you follow this README from the branch in question. |
Member
There was a problem hiding this comment.
The inputstream.adaptive add-on can be build at any time, this is completely unrelated to building pvr.plutotv, as it is a run time dependency, not a build time dependency, thus, not related to pvr.plutotv build procedure.
We need to distinguish between build requirements, which are to be described here and runtime-requirements, which should not be part of this README.
Please remove all inputstream.adaptive information you have added to this file.
Author
There was a problem hiding this comment.
I have considered this suggestion, I agree with it. Without it, however, I believe the changes to the README are insignificant. I will be closing the pull request. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated README to reflect building procedure for Kodi version Piers.