Skip to content

SMB password revealed in debug log #74

@dmittiga

Description

@dmittiga

With debugging logging enabled, the add-on reveals the SMB password when issuing the StreamStartError message. When logging the OpenRecordedStream or OpenLiveStream event, a password safe version of the SMB string is used when available. But later in each method, if the stream fails to open, a StreamStartError message is sent using the unsafe SMB string, revealing the password.

pvr2wmc.cpp lines 1314 and 1577

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions