Skip to content

Go Onix v3 Generation Generates Incomplete Models #40

@nikolawannabe

Description

@nikolawannabe

Looking at the code generated for the objects in the v3 version of onix in Go, and trying to parse XML with said code, lots of properties are missing from this version that should be present.

https://github.com/kogai/onix-codegen/blob/main/generated/go/v3/model.go#L862 vs https://github.com/knakk/kbp/blob/master/onix/message.go#L2890 for example shows these fields missing:

 	RecordReference        RecordReference
	NotificationType       NotificationType
 	DeletionText           []DeletionText
 	RecordSourceType       *RecordSourceType
 	RecordSourceIdentifier []RecordSourceIdentifier
 	RecordSourceName       *RecordSourceName
 	ProductIdentifier      []ProductIdentifier
 	Barcode                []Barcode

I don't see anything immediately obvious with the XSD that would cause this problem, but I'm not an XSD expert by any means, unfortunately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions