Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

presubmit build have one extra argument  #71

@Jeffwan

Description

@Jeffwan
/bin/bash -c /mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator//build_image.sh 

/mnt/test-data-volume/kubeflow-xgboost-operator-presubmit-build-70-9aa764f-7905-1ef1/src/kubeflow/xgboost-operator/Dockerfile 
gcr.io/kubeflow-ci/xgboost-operator 
v1.0

In build_image.sh scripts, we only consume two arguments.

DOCKERFILE=$1
CONTEXT_DIR=$(dirname "$DOCKERFILE")
IMAGE=$2

If we add extra argument, it will v1.0 will be assigned which may brings problems. I meet this problem working on #70

At the beginning, I use TIMEOUT=${3-:30m} then it grants v1.0 to timeout and fail the test.

I think we can either delete v1.0 tag, since build_image.sh generate dirty tags here

TAG=$(git describe --tags --always --dirty)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions