fix computedomain unittest failures#1142
Merged
Merged
Conversation
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
✅ Deploy Preview for dra-driver-nvidia-gpu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
/release-note-none |
Contributor
|
LGTM label has been added. DetailsGit tree hash: dea71b51897e048e956744c08e98d922ec31c933 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tariq1890, varunrsekar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
ComputeDomain DeviceState unittests introduced in #1133 is failing .
This change fixes the
TestPrepareReturnsCheckpointedDevicesForCompletedClaimunittest.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Related PR: #1129
Test passes now:
Does this PR introduce a user-facing change?
Additional documentation (design docs, usage docs, etc.):
Checklist
make check testpasses locallymake check-generatepasses ifapi/changed (CRDs, deepcopy, informers, listers, clientset)make check-modulespasses ifgo.mod/go.sumchangeddeployments/helm) updated if flags, RBAC, or defaults changed