Skip to content

fix computedomain unittest failures#1142

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
varunrsekar:fix-cd-unittests
May 14, 2026
Merged

fix computedomain unittest failures#1142
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
varunrsekar:fix-cd-unittests

Conversation

@varunrsekar
Copy link
Copy Markdown
Contributor

@varunrsekar varunrsekar commented May 14, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

ComputeDomain DeviceState unittests introduced in #1133 is failing .

# sigs.k8s.io/dra-driver-nvidia-gpu/cmd/compute-domain-kubelet-plugin [sigs.k8s.io/dra-driver-nvidia-gpu/cmd/compute-domain-kubelet-plugin.test]
cmd/compute-domain-kubelet-plugin/device_state_test.go:390:17: cannot use &expectedDevice (value of type *kubeletplugin.Device) as *CheckpointedDevice value in struct literal
make: *** [Makefile:105: test] Error 1

This change fixes the TestPrepareReturnsCheckpointedDevicesForCompletedClaim unittest.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Related PR: #1129

Test passes now:

=== RUN   TestPrepareReturnsCheckpointedDevicesForCompletedClaim
--- PASS: TestPrepareReturnsCheckpointedDevicesForCompletedClaim (0.00s)

Does this PR introduce a user-facing change?


Additional documentation (design docs, usage docs, etc.):


Checklist

  • make check test passes locally
  • make check-generate passes if api/ changed (CRDs, deepcopy, informers, listers, clientset)
  • make check-modules passes if go.mod / go.sum changed
  • Tests added or updated for the change
  • Helm chart (deployments/helm) updated if flags, RBAC, or defaults changed

Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for dra-driver-nvidia-gpu ready!

Name Link
🔨 Latest commit 8b6f3c9
🔍 Latest deploy log https://app.netlify.com/projects/dra-driver-nvidia-gpu/deploys/6a061d5eb6205a0008addce8
😎 Deploy Preview https://deploy-preview-1142--dra-driver-nvidia-gpu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from dims and jgehrcke May 14, 2026 19:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2026
@varunrsekar
Copy link
Copy Markdown
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2026
Copy link
Copy Markdown
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: dea71b51897e048e956744c08e98d922ec31c933

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tariq1890, varunrsekar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3687fd5 into kubernetes-sigs:main May 14, 2026
15 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in DRA Driver for NVIDIA GPUs May 14, 2026
@varunrsekar varunrsekar deleted the fix-cd-unittests branch May 14, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants