-
Notifications
You must be signed in to change notification settings - Fork 211
Description
What would you like to be added:
I would like to remove the PriorityName string field from the PriorityBandConfig struct and all downstream usages (metrics, logs, accessors).
Proposed Changes:
- Remove
PriorityNamefrompkg/epp/flowcontrol/registry/config.go(and elsewhere inpkg/epp/flowcontrol). - Remove validation logic checking for duplicate names.
- Update the
DefaultPriorityBandtemplate logic to stop generating names likeDynamic-<int>. - Update
Stats()and Prometheus metrics to identify bands solely by their integerPriorityvalue.
Why is this needed:
Currently, priority bands are assigned a human-readable name (e.g., "High", "Dynamic-100"). However, the relationship between InferenceObjective resources and Priority Bands is N:1; multiple objectives can map to the same integer priority level.
Trying to assign a single name to a band shared by multiple objectives (e.g., "TenantA,TenantB") is complex and leads to ambiguous or confusing observability data.
Since the integer Priority is the unique identifier for the band, the string name provides little mechanical value and invites confusion. Removing it simplifies the configuration model and eliminates the ambiguity.
See: #2006 (comment).
In logging, we should replace this with the InferenceObjective info (Model) bound to the request. This info is being passed through in #2010.