From 90f6f90bd42dc3d208cc2b1ba202ef5e3f285641 Mon Sep 17 00:00:00 2001 From: KGFCH2 Date: Sun, 31 May 2026 21:21:48 +0530 Subject: [PATCH] refactor: catch body-parser JSON syntax errors and improve global error logs --- server/middlewares/errorHandler.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/server/middlewares/errorHandler.js b/server/middlewares/errorHandler.js index f3e788e..1f0fb3e 100644 --- a/server/middlewares/errorHandler.js +++ b/server/middlewares/errorHandler.js @@ -8,8 +8,19 @@ const errorHandler = (err, req, res, next) => { message: message }; + // Log 500 internal errors to the server console for debuggability + if (!err.statusCode || err.statusCode === 500) { + console.error(`[Error] Internal Server Error on ${req.method} ${req.originalUrl}:`, err); + } + + // Handle express malformed JSON parsing error + if (err instanceof SyntaxError && err.status === 400 && 'body' in err) { + statusCode = 400; + message = "Invalid JSON syntax in request body."; + errorResponse.message = message; + } // Handle ApiError - if (err instanceof ApiError) { + else if (err instanceof ApiError) { statusCode = err.statusCode; message = err.message; errorResponse.message = message;