From 00833542361744b103017a1fd4e1b98a2f4f6a4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mert=20Bora=20=C4=B0nevi?= Date: Thu, 16 Oct 2025 23:42:52 +0200 Subject: [PATCH] guard against followees and followers who changed their name If a player who is visible on a follower/followee list changes their name before the viewing player could click their name, it would not be able to find the player by name, and the server would crash. This fix mitigates this by failing early on unknown name. --- .../brainwine/gameserver/server/requests/DialogRequest.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gameserver/src/main/java/brainwine/gameserver/server/requests/DialogRequest.java b/gameserver/src/main/java/brainwine/gameserver/server/requests/DialogRequest.java index 49dfc1c3..e8a27c79 100644 --- a/gameserver/src/main/java/brainwine/gameserver/server/requests/DialogRequest.java +++ b/gameserver/src/main/java/brainwine/gameserver/server/requests/DialogRequest.java @@ -61,6 +61,11 @@ private void showPlayerDialog(Player player) { // Create player info dialog Player subject = GameServer.getInstance().getPlayerManager().getPlayer((String)input[0]); + if(subject == null) { + player.showDialog(DialogHelper.messageDialog("Player not found!")); + return; + } + Dialog dialog = new Dialog().setTitle(subject.getName()); // Online status section