From c86f456fac1fe6852e3ade56d30340e9661e4027 Mon Sep 17 00:00:00 2001 From: kvisidisi Date: Thu, 17 Jul 2025 01:52:31 +0300 Subject: [PATCH 1/5] refactor(collector.Describe): unnecessary log --- internal/collector/collector.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/collector/collector.go b/internal/collector/collector.go index 3d2d5d3..b17c7c5 100644 --- a/internal/collector/collector.go +++ b/internal/collector/collector.go @@ -66,7 +66,6 @@ func (c *Collector) Describe(ch chan<- *prometheus.Desc) { labels, ) ch <- desc - c.logger.Debug("sub-metric description added", "sub-metric", subMetric.Name) } } From da5bb6a2d8e1d54750d85dd34b7a31b442c1ebab Mon Sep 17 00:00:00 2001 From: kvisidisi Date: Thu, 17 Jul 2025 01:54:07 +0300 Subject: [PATCH 2/5] refactor(collector.Describe): added log --- internal/collector/collector.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/collector/collector.go b/internal/collector/collector.go index b17c7c5..0531254 100644 --- a/internal/collector/collector.go +++ b/internal/collector/collector.go @@ -49,7 +49,6 @@ func (c *Collector) Describe(ch chan<- *prometheus.Desc) { metricConfig.Labels) ch <- desc - c.logger.Debug("simple metric description added", "metric", metricConfig.Name) continue } for _, subMetric := range metricConfig.SubMetrics { @@ -68,7 +67,7 @@ func (c *Collector) Describe(ch chan<- *prometheus.Desc) { ch <- desc } } - + c.logger.Debug("metric description reading ended") } func (c *Collector) ReloadConfig() error { From 9c8ee511472f9a9b62cc34f97f275bd520244c35 Mon Sep 17 00:00:00 2001 From: kvisidisi Date: Thu, 17 Jul 2025 01:55:09 +0300 Subject: [PATCH 3/5] refactor(collector.ReloadConfig): duplicated log deleted --- internal/collector/collector.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/collector/collector.go b/internal/collector/collector.go index 0531254..ede4c40 100644 --- a/internal/collector/collector.go +++ b/internal/collector/collector.go @@ -74,7 +74,6 @@ func (c *Collector) ReloadConfig() error { var newCfg config.Config if err := config.Load(c.configPath, &newCfg); err != nil { - c.logger.Error("failed to reload config", "error", err) return err } From f1572d2efee717940105725e359df5ed3d978eaa Mon Sep 17 00:00:00 2001 From: kvisidisi Date: Thu, 17 Jul 2025 01:56:19 +0300 Subject: [PATCH 4/5] refactor(collector.Collect): log level changed due to not trashing logs --- internal/collector/collector.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/collector/collector.go b/internal/collector/collector.go index ede4c40..907ca8a 100644 --- a/internal/collector/collector.go +++ b/internal/collector/collector.go @@ -98,7 +98,7 @@ func (c *Collector) Collect(ch chan<- prometheus.Metric) { Checks.Inc() - c.logger.Info("Metrics collection started") + c.logger.Debug("Metrics collection started") wg := sync.WaitGroup{} @@ -129,5 +129,5 @@ func (c *Collector) Collect(ch chan<- prometheus.Metric) { wg.Wait() - c.logger.Info("Metrics collection finished") + c.logger.Debug("Metrics collection finished") } From 6c8ef56e85aade8ab7675f1ebe20edac748706a2 Mon Sep 17 00:00:00 2001 From: kvisidisi Date: Thu, 17 Jul 2025 01:57:44 +0300 Subject: [PATCH 5/5] refactor(processing): logs deleted due to no trashing --- internal/collector/processing.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/collector/processing.go b/internal/collector/processing.go index adc4f29..7bc133d 100644 --- a/internal/collector/processing.go +++ b/internal/collector/processing.go @@ -94,7 +94,6 @@ func (c *Collector) collectSimpleMetric(ch chan<- prometheus.Metric, metricConfi } ch <- metric } - c.logger.Debug("metric collected successfully", "metric", metricConfig.Name) } // collectComplicatedMetric handles metric group defined with sub-metrics section. @@ -153,7 +152,6 @@ func (c *Collector) collectComplicatedMetric(ch chan<- prometheus.Metric, metric continue } ch <- metric - c.logger.Debug("sub-metric collected successfully", "sub-metric", subMetric.Name) } } }