From 8970a75cb0e46f9689b0c90456b376780fc24599 Mon Sep 17 00:00:00 2001 From: Leonard Crestez Date: Wed, 1 Apr 2026 12:49:28 +0300 Subject: [PATCH 1/3] pre-commit: remove mypy hook This does not currently work because pre-commit executes hooks in a private venv and mypy requires the projects own dependencies. It's possible to make this pass by duplicating dependencies into the pre-commit config file but it is not worth it. --- .pre-commit-config.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7f737a4..de7a82a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -9,7 +9,3 @@ repos: hooks: - id: ruff-check - id: ruff-format - - repo: https://github.com/pre-commit/mirrors-mypy - rev: 'v1.19.0' - hooks: - - id: mypy \ No newline at end of file From a886ae293346f906cf8671f29715c2dfebd865bb Mon Sep 17 00:00:00 2001 From: Leonard Crestez Date: Wed, 1 Apr 2026 12:51:41 +0300 Subject: [PATCH 2/3] github: add pre-commit job By executing pre-commit inside CI we ensure that the config works. --- .github/workflows/lint_test.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/lint_test.yml b/.github/workflows/lint_test.yml index 63b830c..76705ab 100644 --- a/.github/workflows/lint_test.yml +++ b/.github/workflows/lint_test.yml @@ -103,3 +103,15 @@ jobs: minColorRange: 50 maxColorRange: 90 valColorRange: ${{ env.total }} + + + pre-commit: + name: Run pre-commit hooks + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 + with: + python-version-file: .python-version + - uses: pre-commit/action@v3.0.1 From eca60bd5d50b1cfc4eaeb2c96d40a712c31207cc Mon Sep 17 00:00:00 2001 From: Kilian Lackhove Date: Wed, 1 Apr 2026 15:47:39 +0200 Subject: [PATCH 3/3] Revert "github: add pre-commit job" This reverts commit a886ae293346f906cf8671f29715c2dfebd865bb. --- .github/workflows/lint_test.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/workflows/lint_test.yml b/.github/workflows/lint_test.yml index 76705ab..63b830c 100644 --- a/.github/workflows/lint_test.yml +++ b/.github/workflows/lint_test.yml @@ -103,15 +103,3 @@ jobs: minColorRange: 50 maxColorRange: 90 valColorRange: ${{ env.total }} - - - pre-commit: - name: Run pre-commit hooks - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v4 - - uses: actions/setup-python@v5 - with: - python-version-file: .python-version - - uses: pre-commit/action@v3.0.1