CanHaveRequestBody feature for post request with json content.

Author: ladeak

src/CHttpServer/CHttpServer/Http3/Http3Stream.cs

@@ -60,7 +60,8 @@ public Http3Stream(FeatureCollection features)
             (typeof(IHttpResponseFeature), this),
             (typeof(IHttpResponseBodyFeature), this),
             (typeof(IHttpResponseTrailersFeature), this),
-            (typeof(IRequestBodyPipeFeature), this));
+            (typeof(IRequestBodyPipeFeature), this),
+            (typeof(IHttpRequestBodyDetectionFeature), this));
 
         //_features.Add<IHttpRequestBodyDetectionFeature>(this);
         //_features.Add<IHttpRequestLifetimeFeature>(this);
@@ -137,6 +138,7 @@ public async Task ProcessStreamAsync<TContext>(IHttpApplication<TContext> applic
                 }
                 _dataReader.AdvanceTo(readResult.Buffer.GetPosition(totalBufferConsumed), readResult.Buffer.End);
             }
+            await _requestDataToAppPipe.Writer.CompleteAsync();
             if (applicationProcessing != null)
                 await applicationProcessing;
         }
@@ -238,6 +240,7 @@ private StreamReadingStatus NextRequestReadingState(Task? applicationProcessing,
             case 0x0: // DATA
                 if (applicationProcessing == null)
                     throw new Http3ConnectionException(ErrorCodes.H3FrameUnexpected);
+                CanHaveBody = true;
                 streamReadingState = StreamReadingStatus.ReadingPayloadData;
                 break;
             case 0x1: // HEADERS
@@ -257,7 +260,6 @@ private StreamReadingStatus NextRequestReadingState(Task? applicationProcessing,
 
     private async Task CloseStreamAsync()
     {
-        await _requestDataToAppPipe.Writer.CompleteAsync();
         await _requestDataToAppPipe.Reader.CompleteAsync();
         await _dataReader.CompleteAsync();
         await _responseHeaderWriter.CompleteAsync();
@@ -380,3 +382,8 @@ internal partial class Http3Stream : IHttpResponseTrailersFeature
     private readonly Http3ResponseHeaderCollection _responseTrailers;
     public IHeaderDictionary Trailers { get => _responseTrailers; set => throw new PlatformNotSupportedException(); }
 }
+
+internal partial class Http3Stream : IHttpRequestBodyDetectionFeature
+{
+    public bool CanHaveBody { get; set; }
+}

tests/CHttpServer.Tests/Http3/Http3FramingStreamWriterTests.cs

@@ -1,5 +1,4 @@
 using System.Buffers;
-using System.Formats.Asn1;
 using System.Net.Quic;
 using System.Runtime.InteropServices;
 using CHttpServer.Http3;

tests/CHttpServer.Tests/Http3/Http3IntegrationTests.cs

@@ -135,7 +135,7 @@ public async Task HttpContext_WritesResponse()
         Assert.Equal("some content", content);
     }
 
-    [Fact(Skip = "WIP")]
+    [Fact]
     public async Task TestPost()
     {
         var client = CreateClient();

tests/CHttpServer.Tests/Http3/Http3StreamTests.cs

@@ -154,26 +154,28 @@ public async Task SingleWrite_HeaderFrame_ReservedFrame_DataFrame()
         var sut = new Http3Stream([]);
 
         var clientStream = await quicConnection.ClientConnection.OpenOutboundStreamAsync(QuicStreamType.Bidirectional, TestContext.Current.CancellationToken);
-        byte[] data = [.. await GetHeadersFrame(), .. GetData(30), .. GetReservedFrame(750), .. GetData(30)];
+        byte[] data = [.. await GetHeadersFrame(), .. GetData(30), .. GetReservedFrame(750), ..GetData(30)];
         await clientStream.WriteAsync(data, TestContext.Current.CancellationToken);
         await clientStream.FlushAsync(TestContext.Current.CancellationToken);
 
         TaskCompletionSource tcs = new(TaskCreationOptions.RunContinuationsAsynchronously);
         sut.Initialize(null, await serverStreamTask);
-        var testApp = new TestBase.TestApplication(ctx =>
+        var testApp = new TestBase.TestApplication(async ctx =>
         {
             Assert.Equal("/", ctx.Request.Path);
             Assert.Equal("https", ctx.Request.Scheme);
             Assert.Equal("localhost", ctx.Request.Host.ToString());
             Assert.Equal(HttpMethod.Get.ToString(), ctx.Request.Method);
-            // TODO: assert data
+            var content = new MemoryStream();
+            await ctx.Request.BodyReader.CopyToAsync(content);
+            Assert.Equal(60, content.Length);
             tcs.SetResult();
-            return Task.CompletedTask;
         });
         var processing = sut.ProcessStreamAsync(testApp, TestContext.Current.CancellationToken);
 
-        await tcs.Task.WaitAsync(DefaultTimeout, TestContext.Current.CancellationToken);
         clientStream.Close();
+        await tcs.Task.WaitAsync(DefaultTimeout, TestContext.Current.CancellationToken);
+
         await processing;
         await quicConnection.DisposeAsync();
     }
@@ -186,7 +188,7 @@ public async Task SingleWrite_InOrderFrames_Throw()
         var sut = new Http3Stream([]);
 
         var clientStream = await quicConnection.ClientConnection.OpenOutboundStreamAsync(QuicStreamType.Bidirectional, TestContext.Current.CancellationToken);
-        byte[] data = [.. GetData(30), .. await GetHeadersFrame()]; //DATA before HEADERS is in-order
+        byte[] data = [.. GetData(30), .. await GetHeadersFrame()]; // DATA before HEADERS is in-order
         await clientStream.WriteAsync(data, TestContext.Current.CancellationToken);
         await clientStream.FlushAsync(TestContext.Current.CancellationToken);