refactor: replace bigSegmentStatus string with EvaluationReason::BigSegmentsStatus enum #2344
beekldAnnotations
13 warnings and 2 notices
|
cpp-linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:219:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L219
'auto *in_experiment_iter' can be declared as 'const auto *in_experiment_iter'
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:215:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L215
'auto *prerequisite_key_iter' can be declared as 'const auto *prerequisite_key_iter'
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:212:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L212
'auto *rule_id_iter' can be declared as 'const auto *rule_id_iter'
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:209:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L209
'auto *rule_index_iter' can be declared as 'const auto *rule_index_iter'
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:197:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L197
'auto *error_kind_iter' can be declared as 'const auto *error_kind_iter'
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:184:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L184
'auto kind_iter' can be declared as 'const auto *kind_iter'
|
|
/libs/internal/src/serialization/json_evaluation_reason.cpp:182:9 [readability-qualified-auto]:
/libs/internal/src/serialization/json_evaluation_reason.cpp#L182
'auto &json_obj' can be declared as 'const auto &json_obj'
|
|
/libs/common/src/data/evaluation_reason.cpp:107:31 [bugprone-unchecked-optional-access]:
/libs/common/src/data/evaluation_reason.cpp#L107
unchecked access to optional value
|
|
/libs/common/src/data/evaluation_reason.cpp:53:28 [performance-move-const-arg]:
/libs/common/src/data/evaluation_reason.cpp#L53
std::move of the variable 'big_segments_status' of the trivially-copyable type 'std::optional<enum BigSegmentsStatus>' has no effect; remove std::move()
|
|
/libs/common/src/data/evaluation_reason.cpp:35:46 [readability-convert-member-functions-to-static]:
/libs/common/src/data/evaluation_reason.cpp#L35
method 'BigSegmentStatus' can be made static
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0qaUpagAAAACCgAStLhU/Q43YRhOPWMZ/TEFYMzExMDAwMTEzMDI5AEVkZ2U=
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|
|
Run clang-format on libs/internal/tests/evaluation_result_test.cpp:
libs/internal/tests/evaluation_result_test.cpp#L0
File libs/internal/tests/evaluation_result_test.cpp does not conform to Custom style guidelines. (lines 84)
|
|
Run clang-format on libs/common/include/launchdarkly/data/evaluation_reason.hpp:
libs/common/include/launchdarkly/data/evaluation_reason.hpp#L0
File libs/common/include/launchdarkly/data/evaluation_reason.hpp does not conform to Custom style guidelines. (lines 97)
|