feat: add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer #2361
Annotations
13 warnings and 1 notice
|
cpp-linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
|
|
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp:112:15 [readability-uppercase-literal-suffix]:
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp#L112
integer literal has suffix 'u', which is not uppercase
|
|
|
|
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp:61:13 [readability-implicit-bool-conversion]:
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp#L61
implicit conversion '(anonymous namespace)::MockFDv1Source **' -> bool
|
|
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp:57:13 [readability-implicit-bool-conversion]:
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp#L57
implicit conversion 'launchdarkly::server_side::data_components::DataSourceStatusManager **' -> bool
|
|
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp:56:58 [readability-identifier-length]:
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp#L56
parameter name 'sm' is too short, expected at least 3 characters
|
|
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp:39:5 [modernize-use-nodiscard]:
/libs/server-sdk/tests/fdv1_adapter_synchronizer_test.cpp#L39
function 'Identity' should be marked [[nodiscard]]
|
|
/libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.hpp:35:7 [cppcoreguidelines-special-member-functions]:
/libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.hpp#L35
class 'FDv1AdapterSynchronizer' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
|
|
/libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp:130:45 [performance-unnecessary-value-param]:
/libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp#L130
the parameter 'status' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
/libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp:124:64 [performance-unnecessary-value-param]:
/libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp#L124
the parameter 'source_builder' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0qzEragAAAAAIlTkpglp6QIAgWij5NxAGUEhMMzBFREdFMDQxOQBFZGdl
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|
|
Run clang-format on libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp:
libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp#L0
File libs/server-sdk/src/data_systems/fdv2/fdv1_adapter_synchronizer.cpp does not conform to Custom style guidelines. (lines 177)
|