feat: evaluate big segments #2365
Annotations
13 warnings and 3 notices
|
cpp-linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
/libs/server-sdk/src/evaluation/rules.cpp:68:14 [readability-implicit-bool-conversion]:
/libs/server-sdk/src/evaluation/rules.cpp#L68
implicit conversion 'data_components::BigSegmentStoreWrapper *' -> bool
|
|
/libs/server-sdk/src/evaluation/rules.cpp:66:10 [readability-implicit-bool-conversion]:
/libs/server-sdk/src/evaluation/rules.cpp#L66
implicit conversion 'const integrations::Membership *' -> bool
|
|
/libs/server-sdk/src/evaluation/rules.cpp:34:49 [bugprone-unchecked-optional-access]:
/libs/server-sdk/src/evaluation/rules.cpp#L34
unchecked access to optional value
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:173:32 [bugprone-narrowing-conversions:
/libs/server-sdk/src/evaluation/evaluator.cpp#L173
narrowing conversion from 'std::size_t' (aka 'unsigned long') to signed type 'data_model::Flag::Variation' (aka 'long') is implementation-defined
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:157:36 [bugprone-narrowing-conversions:
/libs/server-sdk/src/evaluation/evaluator.cpp#L157
narrowing conversion from 'std::size_t' (aka 'unsigned long') to signed type 'data_model::Flag::Variation' (aka 'long') is implementation-defined
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:126:36 [bugprone-narrowing-conversions:
/libs/server-sdk/src/evaluation/evaluator.cpp#L126
narrowing conversion from 'unsigned long' to signed type 'data_model::Flag::Variation' (aka 'long') is implementation-defined
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:74:40 [readability-identifier-length]:
/libs/server-sdk/src/evaluation/evaluator.cpp#L74
variable name 'p' is too short, expected at least 3 characters
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:64:32 [performance-unnecessary-value-param]:
/libs/server-sdk/src/evaluation/evaluator.cpp#L64
the parameter 'parent_key' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:63:36 [readability-function-cognitive-complexity]:
/libs/server-sdk/src/evaluation/evaluator.cpp#L63
function 'Evaluate' has cognitive complexity of 28 (threshold 25)
|
|
/libs/server-sdk/src/evaluation/evaluator.cpp:34:12 [modernize-return-braced-init-list]:
/libs/server-sdk/src/evaluation/evaluator.cpp#L34
avoid repeating the return type from the declaration; use a braced initializer list instead
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0rTcsagAAAAB5aPgv0sFsQao3MvIaV7KvTEFYRURHRTE5MTMARWRnZQ==
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|
|
Run clang-format on libs/server-sdk/src/evaluation/evaluator.cpp:
libs/server-sdk/src/evaluation/evaluator.cpp#L0
File libs/server-sdk/src/evaluation/evaluator.cpp does not conform to Custom style guidelines. (lines 24)
|
|
Run clang-format on libs/server-sdk/src/evaluation/evaluation_stack.hpp:
libs/server-sdk/src/evaluation/evaluation_stack.hpp#L0
File libs/server-sdk/src/evaluation/evaluation_stack.hpp does not conform to Custom style guidelines. (lines 84)
|
|
Run clang-format on libs/server-sdk/src/evaluation/evaluation_stack.cpp:
libs/server-sdk/src/evaluation/evaluation_stack.cpp#L0
File libs/server-sdk/src/evaluation/evaluation_stack.cpp does not conform to Custom style guidelines. (lines 68, 69)
|