fix: stop accumulating WhenAny continuations on the Conditions aggreg… #2418
beekldAnnotations
13 warnings
|
cpp-linter
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955, MarkusJx/install-boost@3039450bb3dd2e8630d1cf10ec39cb1da3054bbd. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
|
|
|
|
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp:165:30 [performance-unnecessary-value-param]:
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp#L165
the parameter 'token' is copied for each invocation but only used as a const reference; consider making it a const reference
|
|
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp:90:55 [readability-named-parameter]:
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp#L90
all parameters should be named in a function
|
|
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp:79:16 [readability-implicit-bool-conversion]:
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp#L79
implicit conversion 'add_pointer_t<const launchdarkly::server_side::data_interfaces::FDv2SourceResult::Interrupted>' (aka 'const launchdarkly::server_side::data_interfaces::FDv2SourceResult::Interrupted *') -> bool
|
|
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp:77:9 [readability-implicit-bool-conversion]:
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp#L77
implicit conversion 'add_pointer_t<const launchdarkly::server_side::data_interfaces::FDv2SourceResult::ChangeSet>' (aka 'const launchdarkly::server_side::data_interfaces::FDv2SourceResult::ChangeSet *') -> bool
|
|
|
|
|
|
|
|
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp:21:5 [clang-analyzer-optin.cplusplus.VirtualCall]:
/libs/server-sdk/src/data_systems/fdv2/conditions.cpp#L21
Call to virtual method 'TimedCondition::Close' during destruction bypasses virtual dispatch
|
|
cpp-linter
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0Z745agAAAACrF4J7587bQJyhTUVbO8TgQ0hJMzBFREdFMDIyMQBFZGdl
|
|
cpp-linter
Failed to restore: Cache service responded with 400
|