fix: catch all exceptions in Judge.evaluate() to prevent blank metricKey from escaping

Author: mattrmc1

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/Judge.java

@@ -104,69 +104,66 @@ public JudgeResult evaluate(String input, String output, double samplingRate) {
           .build();
     }
 
-    String formatted = "MESSAGE HISTORY:\n" + input + "\n\nRESPONSE TO EVALUATE:\n" + output;
-    LDAIConfigTracker tracker = config.createTracker();
-
-    RunnerResult result;
     try {
-      result = tracker.trackMetricsOf(RunnerResult::getMetrics, () -> runner.run(formatted, EVALUATION_SCHEMA));
-    } catch (Exception ex) {
-      return JudgeResult.builder()
+      String formatted = "MESSAGE HISTORY:\n" + input + "\n\nRESPONSE TO EVALUATE:\n" + output;
+      LDAIConfigTracker tracker = config.createTracker();
+
+      RunnerResult result = tracker.trackMetricsOf(RunnerResult::getMetrics, () -> runner.run(formatted, EVALUATION_SCHEMA));
+
+      Map<String, Object> parsed = result.getParsed();
+      if (parsed == null) {
+        if (logger != null) logger.warn("Judge {}: runner returned null parsed output", config.getKey());
+        return JudgeResult.builder()
+            .sampled(true)
+            .success(false)
+            .judgeConfigKey(config.getKey())
+            .metricKey(config.getEvaluationMetricKey())
+            .build();
+      }
+
+      Object scoreRaw = parsed.get("score");
+      if (!(scoreRaw instanceof Number)) {
+        if (logger != null) logger.warn("Judge {}: parsed output missing numeric score", config.getKey());
+        return JudgeResult.builder()
+            .sampled(true)
+            .success(false)
+            .judgeConfigKey(config.getKey())
+            .metricKey(config.getEvaluationMetricKey())
+            .build();
+      }
+      double score = ((Number) scoreRaw).doubleValue();
+      if (!Double.isFinite(score) || score < 0.0 || score > 1.0) {
+        if (logger != null) logger.warn("Judge {}: score {} is outside [0.0, 1.0]", config.getKey(), score);
+        return JudgeResult.builder()
+            .sampled(true)
+            .success(false)
+            .judgeConfigKey(config.getKey())
+            .metricKey(config.getEvaluationMetricKey())
+            .build();
+      }
+
+      JudgeResult.Builder resultBuilder = JudgeResult.builder()
           .sampled(true)
-          .success(false)
+          .success(true)
           .judgeConfigKey(config.getKey())
           .metricKey(config.getEvaluationMetricKey())
-          .errorMessage(ex.getMessage())
-          .build();
-    }
+          .score(score);
 
-    Map<String, Object> parsed = result.getParsed();
-    if (parsed == null) {
-      if (logger != null) logger.warn("Judge {}: runner returned null parsed output", config.getKey());
-      return JudgeResult.builder()
-          .sampled(true)
-          .success(false)
-          .judgeConfigKey(config.getKey())
-          .metricKey(config.getEvaluationMetricKey())
-          .build();
-    }
+      Object reasoningRaw = parsed.get("reasoning");
+      if (reasoningRaw instanceof String) {
+        resultBuilder.reasoning((String) reasoningRaw);
+      } else if (reasoningRaw != null) {
+        if (logger != null) logger.warn("Judge {}: reasoning is not a string, ignoring", config.getKey());
+      }
 
-    Object scoreRaw = parsed.get("score");
-    if (!(scoreRaw instanceof Number)) {
-      if (logger != null) logger.warn("Judge {}: parsed output missing numeric score", config.getKey());
-      return JudgeResult.builder()
-          .sampled(true)
-          .success(false)
-          .judgeConfigKey(config.getKey())
-          .metricKey(config.getEvaluationMetricKey())
-          .build();
-    }
-    double score = ((Number) scoreRaw).doubleValue();
-    if (!Double.isFinite(score) || score < 0.0 || score > 1.0) {
-      if (logger != null) logger.warn("Judge {}: score {} is outside [0.0, 1.0]", config.getKey(), score);
+      return resultBuilder.build();
+    } catch (Exception ex) {
       return JudgeResult.builder()
           .sampled(true)
           .success(false)
-          .judgeConfigKey(config.getKey())
-          .metricKey(config.getEvaluationMetricKey())
+          .errorMessage(ex.getMessage())
           .build();
     }
-
-    JudgeResult.Builder resultBuilder = JudgeResult.builder()
-        .sampled(true)
-        .success(true)
-        .judgeConfigKey(config.getKey())
-        .metricKey(config.getEvaluationMetricKey())
-        .score(score);
-
-    Object reasoningRaw = parsed.get("reasoning");
-    if (reasoningRaw instanceof String) {
-      resultBuilder.reasoning((String) reasoningRaw);
-    } else if (reasoningRaw != null) {
-      if (logger != null) logger.warn("Judge {}: reasoning is not a string, ignoring", config.getKey());
-    }
-
-    return resultBuilder.build();
   }
 
   /**