From 0b0408727e335f0a03b559fb02a06653ada1a5f2 Mon Sep 17 00:00:00 2001 From: r1n04h Date: Fri, 5 Dec 2025 17:15:07 +0000 Subject: [PATCH 1/4] refactor: biome check --- src/client/components/IndexPage.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/client/components/IndexPage.tsx b/src/client/components/IndexPage.tsx index ff7b4e2..8e457d3 100644 --- a/src/client/components/IndexPage.tsx +++ b/src/client/components/IndexPage.tsx @@ -37,9 +37,9 @@ export function IndexPage({ path: _path }: { path?: string }) { textAlign: 'left', }} > - In-browser, instant, and secure. + In-browser, instant, and secure.

- + {/* CTA Button */} - - From 821e21d1a79b090efa19120d078b32c445fcd124 Mon Sep 17 00:00:00 2001 From: r1n04h Date: Fri, 5 Dec 2025 17:43:18 +0000 Subject: [PATCH 2/4] refactor: tslint --- package.json | 1 + src/assert.ts | 14 ++++++++++---- src/client/components/LoginPage.tsx | 25 ------------------------- src/encryption.ts | 1 + src/spark-service.ts | 4 ++-- 5 files changed, 14 insertions(+), 31 deletions(-) diff --git a/package.json b/package.json index 02dbd22..6a951ca 100644 --- a/package.json +++ b/package.json @@ -8,6 +8,7 @@ "build:watch": "bun build src/client/app.tsx --outdir dist --target browser --watch", "start": "bun run build && PORT=443 bun run src/index.ts", "dev:full": "concurrently \"bun run dev\" \"bun run build:watch\"", + "tslint": "tsc --noEmit", "check": "biome check src/", "check:fix": "biome check --fix src/" }, diff --git a/src/assert.ts b/src/assert.ts index 67e8739..8e1788b 100644 --- a/src/assert.ts +++ b/src/assert.ts @@ -1,15 +1,21 @@ -export const assert = { - ok(value: unknown, message?: string) { +interface Assert { + ok(value: unknown, message?: string): asserts value; + strictEqual(actual: T, expected: T, message?: string): void; + notStrictEqual(actual: T, expected: T, message?: string): void; +} + +export const assert: Assert = { + ok(value: unknown, message?: string): asserts value { if (!value) { throw new Error(message || 'Assertion failed: value is not truthy'); } }, - strictEqual(actual: T, expected: T, message?: string) { + strictEqual(actual: T, expected: T, message?: string): void { if (actual !== expected) { throw new Error(message || `Assertion failed: ${actual} !== ${expected}`); } }, - notStrictEqual(actual: T, expected: T, message?: string) { + notStrictEqual(actual: T, expected: T, message?: string): void { if (actual === expected) { throw new Error(message || `Assertion failed: ${actual} === ${expected}`); } diff --git a/src/client/components/LoginPage.tsx b/src/client/components/LoginPage.tsx index e9e6fcd..e83f3dd 100644 --- a/src/client/components/LoginPage.tsx +++ b/src/client/components/LoginPage.tsx @@ -629,20 +629,6 @@ export function LoginPage({ path: _path }: { path?: string }) { lineHeight: '1.5', textShadow: '0 1px 2px rgba(0, 0, 0, 0.1)', animation: 'pulse 2s infinite', - '@keyframes pulse': { - '0%': { - transform: 'scale(1)', - boxShadow: '0 0 0 0 rgba(255, 255, 255, 0.4)', - }, - '70%': { - transform: 'scale(1.02)', - boxShadow: '0 0 0 10px rgba(255, 255, 255, 0)', - }, - '100%': { - transform: 'scale(1)', - boxShadow: '0 0 0 0 rgba(255, 255, 255, 0)', - }, - }, }} >
⚠️ Important: diff --git a/src/encryption.ts b/src/encryption.ts index 0c9359d..4b1959f 100644 --- a/src/encryption.ts +++ b/src/encryption.ts @@ -1,6 +1,7 @@ import { scryptAsync } from '@noble/hashes/scrypt'; // @ts-ignore dont want to install @types/browserify-cipher as it has incorrect definition of the func we use import * as aes from 'browserify-cipher'; +// @ts-ignore its purejs, we donthave types for it import { hexToUint8Array, uint8ArrayToHex } from './uint8array-extras'; const createCipheriv = aes.createCipheriv; diff --git a/src/spark-service.ts b/src/spark-service.ts index 6a34fc0..e1b1970 100644 --- a/src/spark-service.ts +++ b/src/spark-service.ts @@ -16,8 +16,8 @@ export async function initializeSparkWallet() { }, }); - wallet.on('transfer:claimed', (transferId: string, balance: number) => { - console.log(`Transfer ${transferId} claimed. New balance: ${balance}`); + wallet.on('transfer:claimed', (transferId: string, updatedBalance: bigint) => { + console.log(`Transfer ${transferId} claimed. New balance: ${Number(updatedBalance)}`); }); sparkWallet = wallet; From 946ba9d61d4d4399d9c62b4775ddc193720d4057 Mon Sep 17 00:00:00 2001 From: r1n04h Date: Fri, 5 Dec 2025 17:46:18 +0000 Subject: [PATCH 3/4] ci: tests on GA --- .github/workflows/ci.yml | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..6b42557 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,33 @@ +name: CI + +on: + push: + branches: [ main, master ] + pull_request: + branches: [ main, master ] + +jobs: + test: + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Setup Bun + uses: oven-sh/setup-bun@v1 + with: + bun-version: latest + + - name: Install dependencies + run: bun install + + - name: Run TypeScript type checking + run: bun run tslint + + - name: Run Biome check + run: bun run check + + - name: Run tests + run: bun run test + From 3dfecc5f4995ada670c015f72fcfbd02f3e77a8b Mon Sep 17 00:00:00 2001 From: r1n04h Date: Fri, 5 Dec 2025 17:48:06 +0000 Subject: [PATCH 4/4] ci: tests on GA --- .github/workflows/ci.yml | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b42557..4b932f0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,8 @@ on: branches: [ main, master ] jobs: - test: + tslint: + name: TypeScript Type Check runs-on: ubuntu-latest steps: @@ -24,9 +25,41 @@ jobs: - name: Run TypeScript type checking run: bun run tslint + + check: + name: Biome Check + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Setup Bun + uses: oven-sh/setup-bun@v1 + with: + bun-version: latest + + - name: Install dependencies + run: bun install - name: Run Biome check run: bun run check + + test: + name: Run Tests + runs-on: ubuntu-latest + + steps: + - name: Checkout code + uses: actions/checkout@v4 + + - name: Setup Bun + uses: oven-sh/setup-bun@v1 + with: + bun-version: latest + + - name: Install dependencies + run: bun install - name: Run tests run: bun run test