Fix: `retire` emits `CreditRetired` event before writing retirement record

[legend-esc]

Labels: bug

Description

In retire, the CreditRetired event is emitted before the retirement record is persisted to storage. If the storage write fails after the event is emitted, off-chain indexers will record a retirement that does not exist on-chain.

Expected Behavior

Emit the event only after all storage writes succeed.

Tasks

• Reorder operations: write retirement record first, then emit event
• Add test asserting event is only present when record exists
• Document event ordering guarantee in rustdoc

[playmaker410]

@playmaker410 has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi Maintainer,

I’d love to take this on. I have hands-on experience with Rust, Soroban, Cairo, and TypeScript, and I’m confident I can deliver a solid solution within 24 hours.

Happy to contribute.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @playmaker410 to this issue.

[akindoyinabraham0-collab]

@akindoyinabraham0-collab has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

I will like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @akindoyinabraham0-collab to this issue.

[drips-wave]

Congratulations, @akindoyinabraham0-collab! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 2, 2026.

🧑‍💻 @akindoyinabraham0-collab: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @akindoyinabraham0-collab as part of the Stellar Wave Program's 5th Wave 🥳

😎 @akindoyinabraham0-collab: You earned 150 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.