From 523f459c025f0997008ab3e53166420021d534df Mon Sep 17 00:00:00 2001 From: Pete Clark Date: Tue, 11 Aug 2026 22:11:47 +0000 Subject: [PATCH] fix(cores): pin libretro-uae to the 2.6.1 branch it actually tracks My mass pin in #18 clobbered an existing pin. libretro-uae is not built from the default branch - libretro-uae_BRANCH = 2.6.1 makes the clone track a release branch - but the pin I added pointed at the default branch HEAD, and _HASH is checked out after the clone, so it won. 2.6.1 sets TARGET_NAME := puae2021 and master sets TARGET_NAME := puae, so the build produced puae_libretro.so while the makefile went looking for puae2021_libretro.so: mv: cannot stat 'src/libretro-uae/puae2021_libretro.so': No such file Repin to 6636d5f, the tip of 2.6.1, which keeps the reproducibility #18 was after without moving the core off its release branch. Both platform patches apply there, and its Makefile sets TARGET_NAME := puae2021 as expected. libretro-uae is the only core with a _BRANCH override, so it is the only one affected. The verification script behind #18 fetched origin HEAD unconditionally and so could not have caught this - noted in #16 for the automation. --- workspace/tg5040/cores/makefile | 6 +++++- workspace/tg5050/cores/makefile | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/workspace/tg5040/cores/makefile b/workspace/tg5040/cores/makefile index 7bf3ce8e5..385eb6a39 100755 --- a/workspace/tg5040/cores/makefile +++ b/workspace/tg5040/cores/makefile @@ -80,7 +80,11 @@ gearcoleco_HASH = 8916216764ca8a7965be5f4b4d093a437a1749a6 gpsp_HASH = 5b6e751f4abf368509146cd143c949c1946ac1ae handy_HASH = bc55d462f0b2d6b073ea93dc552ebd73cec60fd1 libretro-cap32_HASH = 4abfb8be233bec630f369379fb6c1d92d31f1c7d -libretro-uae_HASH = 96ebfcfc2c66233ad37f6dc99ee991211dc719ad +# NOTE: this core tracks the 2.6.1 branch (see libretro-uae_BRANCH below), not the +# default branch. 2.6.1 builds TARGET_NAME puae2021, master builds puae, so a pin +# off master silently produces a .so this makefile cannot find. Keep this SHA on +# the 2.6.1 branch. +libretro-uae_HASH = 6636d5f3fd4417f4e57ab9144fdba35b77fa3a40 mednafen_pce_fast_HASH = b211204c7026dff6e86e79b00185512e2421fff8 mednafen_supafaust_HASH = d6187e5337e6c2646d003db3ab1936727ca75301 mednafen_vb_HASH = 3f53a40bf8aa18777514fd4b220960427e312a3f diff --git a/workspace/tg5050/cores/makefile b/workspace/tg5050/cores/makefile index 7bf3ce8e5..385eb6a39 100755 --- a/workspace/tg5050/cores/makefile +++ b/workspace/tg5050/cores/makefile @@ -80,7 +80,11 @@ gearcoleco_HASH = 8916216764ca8a7965be5f4b4d093a437a1749a6 gpsp_HASH = 5b6e751f4abf368509146cd143c949c1946ac1ae handy_HASH = bc55d462f0b2d6b073ea93dc552ebd73cec60fd1 libretro-cap32_HASH = 4abfb8be233bec630f369379fb6c1d92d31f1c7d -libretro-uae_HASH = 96ebfcfc2c66233ad37f6dc99ee991211dc719ad +# NOTE: this core tracks the 2.6.1 branch (see libretro-uae_BRANCH below), not the +# default branch. 2.6.1 builds TARGET_NAME puae2021, master builds puae, so a pin +# off master silently produces a .so this makefile cannot find. Keep this SHA on +# the 2.6.1 branch. +libretro-uae_HASH = 6636d5f3fd4417f4e57ab9144fdba35b77fa3a40 mednafen_pce_fast_HASH = b211204c7026dff6e86e79b00185512e2421fff8 mednafen_supafaust_HASH = d6187e5337e6c2646d003db3ab1936727ca75301 mednafen_vb_HASH = 3f53a40bf8aa18777514fd4b220960427e312a3f