Skip to content

Commit e0d98bb

Browse files
author
Antigravity Agent
committed
Fix PR check errors: mypy, poetry deprecation, and test failure
1 parent 5f7c769 commit e0d98bb

3 files changed

Lines changed: 21 additions & 16 deletions

File tree

pyproject.toml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,30 @@
22

33
# PROJECT
44

5-
[tool.poetry]
5+
[project]
66
name = "regression_model_template"
77
version = "2.0.0"
88
description = "Predict the number of regression_model_template available."
9-
repository = "https://github.com/lgcorzo/mlops-python-package"
10-
documentation = "https://lgcorzo.github.io/mlops-python-package/"
11-
authors = []
9+
authors = [{ name = "lgcorzo" }]
1210
readme = "README.md"
1311
license = "MIT"
1412
keywords = ["mlops", "python", "package"]
15-
packages = [{ include = "regression_model_template", from = "src" }]
13+
requires-python = ">=3.12"
14+
classifiers = [
15+
"Programming Language :: Python :: 3",
16+
"Programming Language :: Python :: 3.12",
17+
]
18+
dynamic = ["dependencies"]
1619

17-
# SCRIPTS
20+
[project.urls]
21+
repository = "https://github.com/lgcorzo/mlops-python-package"
22+
documentation = "https://lgcorzo.github.io/mlops-python-package/"
1823

19-
[tool.poetry.scripts]
20-
regression_model_template = 'regression_model_template.scripts:main'
24+
[project.scripts]
25+
regression_model_template = "regression_model_template.scripts:main"
2126

22-
# DEPENDENCIES
27+
[tool.poetry]
28+
packages = [{ include = "regression_model_template", from = "src" }]
2329

2430
[tool.poetry.dependencies]
2531
python = "^3.12"
@@ -49,7 +55,6 @@ opentelemetry-exporter-otlp = "^1.30.0"
4955
confluent-kafka = "^2.8.2"
5056
fastapi = "^0.115.11"
5157

52-
5358
[tool.poetry.group.checks.dependencies]
5459
bandit = "^1.7.9"
5560
coverage = "^7.5.4"

src/regression_model_template/controller/kafka_app.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import logging
77
import time
88
import json
9+
import typing as T
910
from typing import Any, Dict, Callable
1011

1112
import uvicorn
@@ -183,7 +184,7 @@ def _process_message(self, msg: Message) -> None:
183184
prediction_result = self.prediction_callback(input_obj).result
184185
except Exception as e:
185186
logger.exception(f"Error during prediction processing: {e}")
186-
predictionresponse.result["error"] = "Internal Processing Error"
187+
predictionresponse.result["error"] = "An error occurred during prediction processing."
187188
prediction_result = predictionresponse.result
188189

189190
try:
@@ -220,7 +221,7 @@ def stop(self) -> None:
220221

221222

222223
# Global Service Instance
223-
fastapi_kafka_service: Any = None
224+
fastapi_kafka_service: "FastAPIKafkaService" = T.cast("FastAPIKafkaService", None)
224225

225226

226227
# FastAPI Endpoints
@@ -239,7 +240,7 @@ async def predict(request: PredictionRequest) -> PredictionResponse: # Use glob
239240
prediction_result = fastapi_kafka_service.prediction_callback(request)
240241
logger.info(f"HTTP prediction result: {prediction_result}")
241242
return prediction_result # Use the global class
242-
except Exception as e:
243+
except Exception:
243244
logger.exception("Error processing HTTP prediction request:")
244245
raise HTTPException(status_code=500, detail="Internal Server Error")
245246

@@ -269,7 +270,7 @@ def predict(self, input_data: PredictionRequest) -> PredictionResponse:
269270
logger.exception(f"Prediction failed: {e}")
270271
predictionresponse.result["inference"] = 0
271272
predictionresponse.result["quality"] = 0
272-
predictionresponse.result["error"] = "Internal Processing Error"
273+
predictionresponse.result["error"] = "An error occurred during prediction processing."
273274
return predictionresponse
274275

275276

tests/controller/test_kafka_app_security.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
PredictionRequest,
66
PredictionService,
77
predict,
8-
PredictionResponse,
98
)
109
import asyncio
1110

@@ -25,7 +24,7 @@ def test_prediction_service_sanitization():
2524
response = service.predict(request)
2625

2726
# Verify
28-
assert response.result["error"] == "Internal Processing Error"
27+
assert response.result["error"] == "An error occurred during prediction processing."
2928
assert sensitive_error not in response.result["error"]
3029
assert response.result["quality"] == 0
3130
assert response.result["inference"] == 0

0 commit comments

Comments
 (0)