RFC: Node.js server side frameworks

[erezmus]

Problem

As of January 2020, Libero Publisher uses Koa, while LIbero Reviewer is using NestJS and Express. As such there is currently no documentation or ADR as to the reasons for those choices and whether we continue with those choices.

Suggestion

• The Reviewer team initially chose NestJS as it has GraphQL support as well as other useful features that ship as part of the framework. However, it seems to be proving boilerplate heavy and it might lesten the cognitive load on developers to drop it in favour of one framework (e.g. Express). Third party packages can be used to provide the desired features for GraphQL, logging and security amongst others that NestJS provides.
• Compare Express and Koa and determine if we should keep using both and if so highlight reasons for using one or the other. Ideally we would want to keep using one framework per product.

[thewilkybarkid]

Ideally we would want to keep using one framework per team.

One framework across Libero, or one framework per product?

[erezmus]

Ideally we would want to keep using one framework per team.

One framework across Libero, or one framework per product?

Per product, corrected.

[thewilkybarkid]

Compare Express and Koa

Express and NestJS? (Seems to be about Reviewer using two frameworks rather than Publisher and Reviewer using different ones?)

[erezmus]

Compare Express and Koa

Express and NestJS?

I don't think its really needed, since its only being used in one repository and i don't think we would use it for something else, but could be wrong

[erezmus]

we dropped nestjs for libero reviewer, see libero/reviewer-submission#37