Skip to content

Commit 831b5fd

Browse files
Copilotlijy91
andcommitted
Fix PIMPL class naming and add missing library pragmas for Windows
Co-authored-by: lijy91 <3889523+lijy91@users.noreply.github.com>
1 parent a2d5053 commit 831b5fd

5 files changed

Lines changed: 14 additions & 4 deletions

File tree

src/platform/windows/accessibility_manager_windows.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
#include <windows.h>
44
#include <oleacc.h>
55

6+
#pragma comment(lib, "oleacc.lib")
7+
68
namespace nativeapi {
79

810
void AccessibilityManager::Enable() {

src/platform/windows/tray_icon_windows.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
#include <string>
66
#include <vector>
77
#include <memory>
8+
9+
#pragma comment(lib, "shell32.lib")
10+
811
#include "../../tray_icon.h"
912
#include "../../menu.h"
1013
#include "../../tray_icon_event.h"

src/platform/windows/tray_manager_windows.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
#include <memory>
44
#include <mutex>
55

6+
#pragma comment(lib, "shell32.lib")
7+
68
#include "../../tray_icon.h"
79
#include "../../tray_manager.h"
810

src/platform/windows/tray_windows.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
#include <string>
66
#include <vector>
77
#include <memory>
8+
9+
#pragma comment(lib, "shell32.lib")
10+
811
#include "../../tray.h"
912
#include "../../menu.h"
1013

src/platform/windows/window_manager_windows.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
namespace nativeapi {
1313

1414
// Private implementation for Windows (stub for now)
15-
class WindowManager::WindowManagerImpl {
15+
class WindowManager::Impl {
1616
public:
17-
WindowManagerImpl(WindowManager* manager) : manager_(manager) {}
18-
~WindowManagerImpl() {}
17+
Impl(WindowManager* manager) : manager_(manager) {}
18+
~Impl() {}
1919

2020
void SetupEventMonitoring() {
2121
// TODO: Implement Windows-specific event monitoring
@@ -29,7 +29,7 @@ class WindowManager::WindowManagerImpl {
2929
WindowManager* manager_;
3030
};
3131

32-
WindowManager::WindowManager() : pimpl_(std::make_unique<WindowManagerImpl>(this)) {
32+
WindowManager::WindowManager() : pimpl_(std::make_unique<Impl>(this)) {
3333
SetupEventMonitoring();
3434
}
3535

0 commit comments

Comments
 (0)