Skip to content

Some libraries in vendor.json are not supported upstream and should be replaced #1253

@rodrigc

Description

@rodrigc

Is this a BUG REPORT or FEATURE REQUEST?:

FEATURE REQUEST

What happened:

In vendor.json, there are these libraries which are not supported upstream:

  • "path": "go.pedge.io/env"
  • "path": "go.pedge.io/lion"
  • "path": "go.pedge.io/lion/current"
  • "path": "go.pedge.io/lion/env"
  • "path": "go.pedge.io/lion/grpc"
  • "path": "go.pedge.io/lion/syslog"
  • "path": "go.pedge.io/pb/go/google/protobuf"
  • "path": "go.pedge.io/pkg/cobra"
  • "path": "go.pedge.io/proto/time"

If you try to rebuild the vendor tree with these libraries, it will fail, because go.pedge.io does not resolve in DNS.

There are three recommendations as to how to move forward:

OPTION 1

Leave these libraries in vendor/ and do not rebuild the vendor tree

OPTION 2

Copy these libraries to an internal/old package and rewrite the imports within each one to be within for example github.com/libopenstorage/openstorage/internal/old/

OPTION 3

Get off these libraries, since they are not maintained.

  • env can be replaced by spf13/viper
  • lion can be replaced with go.uber.org/zap
  • proto/time, pb/google/protobuf are just simple helpers. libopenstorage may have replacements already
  • pkg/cobra is just simple helpers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions