From 005a21d02985d5ab71b69203884baab3d4f87ba9 Mon Sep 17 00:00:00 2001 From: Billy Robert O'Neal III Date: Fri, 17 Apr 2026 15:32:35 -0700 Subject: [PATCH 1/2] Remove REQUIRED from find_dependency. The purpose of find_dependency is to propagate REQUIRED-ness from the caller into dependencies, if required. That is, find_package(libscran_umappp QUIET) should make the inner search for Eigen3 itself QUIET, but putting REQUIRED there breaks this. Also fixed the order to exactly match the find_package block: https://github.com/BillyONeal/umappp/blob/8a6efdf0b5be73310fc079640127072b99332f75/CMakeLists.txt#L25-L30 --- cmake/Config.cmake.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cmake/Config.cmake.in b/cmake/Config.cmake.in index 54ae53d..603cf93 100644 --- a/cmake/Config.cmake.in +++ b/cmake/Config.cmake.in @@ -1,11 +1,11 @@ @PACKAGE_INIT@ include(CMakeFindDependencyMacro) -find_dependency(ltla_aarand 1.1.0 CONFIG REQUIRED) -find_dependency(ltla_sanisizer 0.2.0 CONFIG REQUIRED) -find_dependency(ltla_subpar 0.5.0 CONFIG REQUIRED) -find_dependency(ltla_irlba 3.1.0 CONFIG REQUIRED) -find_dependency(Eigen3 5.0.0 CONFIG REQUIRED) -find_dependency(knncolle_knncolle 3.1.0 CONFIG REQUIRED) +find_dependency(ltla_aarand 1.1.0 CONFIG) +find_dependency(ltla_irlba 3.1.0 CONFIG) +find_dependency(Eigen3 5.0.0 CONFIG) +find_dependency(ltla_subpar 0.5.0 CONFIG) +find_dependency(ltla_sanisizer 0.2.0 CONFIG) +find_dependency(knncolle_knncolle 3.1.0 CONFIG) include("${CMAKE_CURRENT_LIST_DIR}/libscran_umapppTargets.cmake") From 096ed3c5293106fcc2ead966fed44346ab1c1195 Mon Sep 17 00:00:00 2001 From: LTLA Date: Wed, 22 Apr 2026 18:23:52 +1000 Subject: [PATCH 2/2] Version bump. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 078d0d0..6f9146c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,7 +1,7 @@ cmake_minimum_required(VERSION 3.14...3.25) project(umappp - VERSION 3.3.1 + VERSION 3.3.2 DESCRIPTION "A C++ implementation of the UMAP algorithm" LANGUAGES CXX)